This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer: fast fail on some error in ddl execution #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
================================================
- Coverage 60.7287% 60.5672% -0.1615%
================================================
Files 134 134
Lines 14848 14843 -5
================================================
- Hits 9017 8990 -27
- Misses 4962 4982 +20
- Partials 869 871 +2 |
csuzhangxc
reviewed
Oct 17, 2019
csuzhangxc
added
status/LGT1
|
@WangXiangUSTC PTAL |
WangXiangUSTC
added
status/LGT2
WangXiangUSTC
approved these changes
Oct 17, 2019
|
cherry pick to release-1.0 failed |
amyangfei
added a commit
to amyangfei/dm
that referenced
this pull request
Oct 17, 2019
amyangfei
added a commit
that referenced
this pull request
Oct 18, 2019
amyangfei
added
already-cherry-pick-1.0
csuzhangxc
added
already-update-release-note
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
syncer doesn't need to retry on the unsupported DDL execution error, such as
can't drop column with index,unsupported drop integer primary key, etc. Pause task directly with error is enough when meeting these errors.What is changed and how it works?
add error blacklist in db operation retryable decision
Check List
Tests
Code changes
Side effects
Related changes
Fast fail on some TiDB unsupported DDL error in the binlog replication unit.