Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: fast fail on some error in ddl execution (#317) #321

Merged
merged 1 commit into from
Oct 18, 2019
Merged

syncer: fast fail on some error in ddl execution (#317) #321

merged 1 commit into from
Oct 18, 2019

Conversation

amyangfei
Copy link
Contributor

cherry-pick #317 into release-1.0

@amyangfei amyangfei added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 17, 2019
csuzhangxc
csuzhangxc reviewed Oct 17, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do not forget to update labels in #317

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 17, 2019
@amyangfei
Copy link
Contributor Author

oops, found data race in unit test

@amyangfei
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@bdee293). Click here to learn what that means.
The diff coverage is 27.2727%.

@@               Coverage Diff                @@
##             release-1.0       #321   +/-   ##
================================================
  Coverage               ?   60.5942%           
================================================
  Files                  ?        134           
  Lines                  ?      14843           
  Branches               ?          0           
================================================
  Hits                   ?       8994           
  Misses                 ?       4980           
  Partials               ?        869

@csuzhangxc
Copy link
Member

@WangXiangUSTC PTAL

WangXiangUSTC
WangXiangUSTC approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 18, 2019
@amyangfei amyangfei merged commit a4412d5 into pingcap:release-1.0 Oct 18, 2019
@amyangfei amyangfei deleted the cherry-pick-317 branch October 18, 2019 02:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyangfei @csuzhangxc @WangXiangUSTC