Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dmctl: optimize query-status info #356

Merged
merged 4 commits into from
Nov 14, 2019
Merged

dmctl: optimize query-status info #356

merged 4 commits into from
Nov 14, 2019

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Some users don't know how to query-status after the info is simplified.

What is changed and how it works?

Add more info for query-status in dmctl.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@lichunzhu lichunzhu added priority/normal Minor change, requires approval from ≥1 primary reviewer needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated status/PTAL This PR is ready for review. Add this label back after committing new changes needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Nov 14, 2019
@lichunzhu
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

1 similar comment
@lichunzhu
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

@WangXiangUSTC
Copy link
Contributor

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Nov 14, 2019
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

csuzhangxc
csuzhangxc approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Nov 14, 2019
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #356   +/-   ##
=========================================
  Coverage   57.693%   57.693%           
=========================================
  Files          160       160           
  Lines        16151     16151           
=========================================
  Hits          9318      9318           
  Misses        5923      5923           
  Partials       910       910

@csuzhangxc csuzhangxc merged commit 94e4235 into pingcap:master Nov 14, 2019
@sre-bot sre-bot mentioned this pull request Nov 14, 2019
Merged
@sre-bot
Copy link

sre-bot commented Nov 14, 2019

cherry pick to release-1.0 in PR #357

@sre-bot sre-bot added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Nov 14, 2019
@lichunzhu lichunzhu deleted the czli/addMoreQueryStatusInfo branch November 15, 2019 06:14
csuzhangxc pushed a commit that referenced this pull request Nov 15, 2019
@sre-bot @csuzhangxc
dmctl: optimize query-status info (#356) (#357)
d0176e5
@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Mar 13, 2020
lichunzhu added a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@lichunzhu @csuzhangxc
dmctl: optimize query-status info (pingcap#356)
2d8d5c2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked already-update-docs The docs related to this PR already updated. Add this label once the docs are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lichunzhu @WangXiangUSTC @csuzhangxc @sre-bot