Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dmctl: optimize query-status info (#356) #357

Merged
merged 4 commits into from
Nov 15, 2019
Merged

dmctl: optimize query-status info (#356) #357

merged 4 commits into from
Nov 15, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Nov 14, 2019

cherry-pick #356 to release-1.0

What problem does this PR solve?

Some users don't know how to query-status after the info is simplified.

What is changed and how it works?

Add more info for query-status in dmctl.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@sre-bot sre-bot mentioned this pull request Nov 14, 2019
Merged
@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated type/cherry-pick This PR is just a cherry-pick (backport) labels Nov 14, 2019
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

csuzhangxc
csuzhangxc reviewed Nov 14, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Nov 14, 2019
@lichunzhu
Copy link
Contributor

/run-all-tests tidb=release-3.0

IANTHEREAL
IANTHEREAL approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Nov 15, 2019
@lichunzhu
Copy link
Contributor

/run-all-tests tidb=release-3.0

1 similar comment
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #357 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #357   +/-   ##
==============================================
  Coverage      57.5001%   57.5001%           
==============================================
  Files              158        158           
  Lines            16033      16033           
==============================================
  Hits              9219       9219           
  Misses            5909       5909           
  Partials           905        905

@csuzhangxc csuzhangxc merged commit d0176e5 into pingcap:release-1.0 Nov 15, 2019
@ericsyh ericsyh modified the milestones: v1.0.2, v1.0.3, test Nov 22, 2019
@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @csuzhangxc @lichunzhu @IANTHEREAL @WangXiangUSTC @ericsyh