This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
loader/syncer: fix bug in #355 #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
Coverage ? 57.534%
==========================================
Files ? 163
Lines ? 16432
Branches ? 0
==========================================
Hits ? 9454
Misses ? 6054
Partials ? 924 |
csuzhangxc
reviewed
Nov 28, 2019
|
/run-all-tests tidb=release-3.0 |
|
@csuzhangxc PTAL |
csuzhangxc
reviewed
Nov 29, 2019
pkg/log/log.go
Outdated
| return | ||
| } | ||
| if field.Type == zapcore.ErrorType { |
There was a problem hiding this comment.
- How about using a
switchto checkfiled.Typefirst? - Can you add a unit test case for this? ref https://github.com/pingcap/tidb-lightning/blob/605760d1b2025d1e1a8b7d0c668c74863d7d1271/lightning/log/log_test.go#L43.
pkg/log/testlogger.go
Outdated
| "go.uber.org/zap/zaptest" | ||
| ) | ||
|
|
||
| // MakeTestLogger creates a Logger instance which produces JSON logs. |
There was a problem hiding this comment.
how add a note this function only used for test?
There was a problem hiding this comment.
or we can move it to test file
|
/run-all-tests tidb=release-3.0 |
|
@WangXiangUSTC Revised. PTAL |
|
LGTM |
WangXiangUSTC
added
status/LGT1
csuzhangxc
added
status/LGT2
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
* fix situations when there is extra msg in error.Error * add deal for zap.Error and add UT
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Son PR of #355.
log.ShortError(err)may contains extra msg forcontext.Canceled.What is changed and how it works?
change
==tostrings.ContainsCheck List
Tests