This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
loader/syncer: filter context cancel error while executing sqls (#355) #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
priority/normal
lichunzhu
added
status/DNM
lichunzhu
changed the title
…/release1.0/filterContextCancelError
|
/run-all-tests tidb=release-3.0 |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #382 +/- ##
===================================================
- Coverage 57.3099% 57.1614% -0.1485%
===================================================
Files 158 159 +1
Lines 16074 16135 +61
===================================================
+ Hits 9212 9223 +11
- Misses 5956 6007 +51
+ Partials 906 905 -1 |
|
@WangXiangUSTC PTAL |
WangXiangUSTC
added
status/LGT2
csuzhangxc
removed
the
status/DNM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #355 and #381 to release-1.0
What problem does this PR solve?
When an error occurs and the context in loader/syncer is canceled, the normally running sql will be canceled and return a
context.Cancelederror, which will confuse the users.What is changed and how it works?
Filter all the
context.Canceledin loader/syncer. Don't return error and don't print log.Check List
Tests
Related changes