This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: use dumpling's finish building connection location to leave safe mode #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-cherry-pick-release-1.0
lance6716
changed the title
lance6716
added
status/WIP
lance6716
added
status/PTAL
|
/run-all-tests |
|
waiting dumpling to record exit binlog location in metadata files |
GMHDBJD
added
status/WIP
This comment has been minimized.
This comment has been minimized.
lance6716
removed
the
needs-cherry-pick-release-1.0
lance6716
commented
Aug 31, 2020
| @@ -0,0 +1,181 @@ | |||
| // Copyright 2019 PingCAP, Inc. | |||
There was a problem hiding this comment.
renamed from pkg/utils/mydumper.go to avoid importing cycle
csuzhangxc
reviewed
Sep 2, 2020
There was a problem hiding this comment.
maybe we should save exit location to checkpoint table, to handle worker switch before exit safe mode.
the case:
- start task with --consistency none and enter sync stage
- flush checkpoint for sync unit
- pause-task
- resume-task
Should save exit location to checkpoint table?
| @@ -1094,7 +1094,7 @@ func (s *Syncer) Run(ctx context.Context) (err error) { | |||
| if s.cfg.Mode == config.ModeAll { | |||
| if err = s.flushCheckPoints(); err != nil { | |||
| s.tctx.L().Warn("fail to flush checkpoints when starting task", zap.Error(err)) | |||
| } else { | |||
| } else if s.cfg.CleanDumpFile { | |||
There was a problem hiding this comment.
this may fix the error in #941?
There was a problem hiding this comment.
we default enabled CleanDumpFile, so if this line was added #941 still happens. Maybe we should check downstream checkpoint, if not exist then load from file 😢
There was a problem hiding this comment.
previous if fresh can achieve this?
Yes, going to change checkpoint structure, implement DM version update changes, and Maybe we should check downstream checkpoint, if not exist then load from file in new PR |
csuzhangxc
added
status/LGT1
|
/run-all-tests |
GMHDBJD
added
status/LGT2
|
cherry pick to release-2.0 failed |
lance6716
added a commit
to lance6716/dm
that referenced
this pull request
Sep 3, 2020
lance6716
added
already-cherry-pick-2.0
lance6716
added a commit
that referenced
this pull request
Sep 3, 2020
7 tasks
csuzhangxc
added
already-update-release-note
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #907
What is changed and how it works?
when dump unit can't assure consistency (for example migrate Aurora, or maybe we could support more scenario to avoid FTWRL), between start and ending of dumping's creating connections, binlog maybe duplicated with dump result, so we should enable safe mode in this period. originally safe mode was turned on for 5 minutes, this PR assure safe mode will keep for enough time.
maybe we should save exit location to checkpoint table, to handle worker switch before exit safe mode. This will achieve in another PR including updating strategy
Check List
Tests
Code changes
Side effects
Related changes