Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: update "safe mode" #444

Merged
merged 8 commits into from
Oct 27, 2020
Merged

zh: update "safe mode" #444

merged 8 commits into from
Oct 27, 2020

Conversation

lance6716
Copy link
Contributor

What is changed, added or deleted? (Required)

add some description about "safe mode". some feature are aligned with pingcap/dm#915

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@CharLotteiu CharLotteiu added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Oct 27, 2020
zh/glossary.md Outdated Show resolved Hide resolved
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
zh/glossary.md Outdated Show resolved Hide resolved
zh/glossary.md Show resolved Hide resolved
zh/glossary.md Outdated Show resolved Hide resolved
lance6716 and others added 3 commits October 27, 2020 17:21
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

zh/glossary.md Outdated

- 启动或恢复增量复制任务的前 5 分钟保持启用
- 任务配置文件中设置 `safe-mode: true` 时会始终启用
- 给全量迁移任务中的 dump 处理单元配置 `--consistency none` 后,在增量复制阶段处理可能不一致的 binlog 时保持启用
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 不一致 有点迷惑?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CharLotteiu CharLotteiu self-assigned this Oct 27, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 27, 2020
@yikeke
Copy link
Contributor

yikeke commented Oct 27, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 6c8c548 into pingcap:master Oct 27, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Oct 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 27, 2020
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #450

ti-srebot added a commit that referenced this pull request Oct 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@CharLotteiu CharLotteiu mentioned this pull request Oct 29, 2020
7 tasks
@CharLotteiu CharLotteiu added translation/done This PR has been translated. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants