This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
config: check and correct format of addr and URL #937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-cherry-pick-release-2.0
This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0
status/PTAL
This PR is ready for review. Add this label back after committing new changes
priority/normal
Minor change, requires approval from ≥1 primary reviewer
type/bug-fix
Bug fix
labels
Aug 27, 2020
lance6716
added
the
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
label
Aug 27, 2020
CI failed |
will check |
csuzhangxc
reviewed
Aug 27, 2020
csuzhangxc
reviewed
Aug 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Aug 28, 2020
seems gRPC (at lease our specified version) should remove
|
GMHDBJD
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GMHDBJD
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Aug 28, 2020
cherry pick to release-2.0 in PR #955 |
ti-srebot
added
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
and removed
needs-cherry-pick-release-2.0
This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0
labels
Aug 28, 2020
csuzhangxc
pushed a commit
that referenced
this pull request
Aug 28, 2020
csuzhangxc
added
already-update-docs
The docs related to this PR already updated. Add this label once the docs are updated
and removed
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
labels
Aug 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
already-update-docs
The docs related to this PR already updated. Add this label once the docs are updated
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/bug-fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
check and correct format of addr and URL in config files
What is changed and how it works?
for xxx-addr, it should not have a scheme. for xxx-urls and its parent config, such as join, initial-cluster, element in it should have a scheme
Check List
Tests
Code changes
Side effects
Related changes