Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: update join config #303

Merged
merged 1 commit into from
Aug 27, 2020
Merged

zh: update join config #303

merged 1 commit into from
Aug 27, 2020

Conversation

lance6716
Copy link
Contributor

What is changed, added or deleted? (Required)

join is used in etcdutil.CreateClient where needs endpoint, which should be URLs

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@ireneontheway ireneontheway added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Aug 27, 2020
@ireneontheway ireneontheway self-assigned this Aug 27, 2020
Copy link
Contributor

@ireneontheway ireneontheway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @TomShawn

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 27, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 27, 2020
@TomShawn TomShawn merged commit a7068bb into pingcap:master Aug 27, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Aug 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2020
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #305

ti-srebot added a commit that referenced this pull request Aug 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ireneontheway ireneontheway added translation/done This PR has been translated. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 31, 2020
@ireneontheway ireneontheway mentioned this pull request Aug 31, 2020
7 tasks
@ti-srebot ti-srebot mentioned this pull request Sep 1, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants