-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh: update join config #303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ireneontheway
added
needs-cherry-pick-release-2.0
Should cherry pick this PR to release-2.0 branch.
size/small
Changes of a small size.
translation/doing
This PR’s assignee is translating this PR.
labels
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @TomShawn
csuzhangxc
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TomShawn
approved these changes
Aug 27, 2020
ti-srebot
approved these changes
Aug 27, 2020
ti-srebot
pushed a commit
to ti-srebot/docs-dm
that referenced
this pull request
Aug 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
7 tasks
cherry pick to release-2.0 in PR #305 |
ti-srebot
added a commit
that referenced
this pull request
Aug 27, 2020
ireneontheway
added
translation/done
This PR has been translated.
and removed
translation/doing
This PR’s assignee is translating this PR.
labels
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-cherry-pick-release-2.0
Should cherry pick this PR to release-2.0 branch.
size/small
Changes of a small size.
status/LGT2
Indicates that a PR has LGTM 2.
translation/done
This PR has been translated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
join
is used inetcdutil.CreateClient
where needs endpoint, which should be URLsWhich DM version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?