Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update system variable #11505

Merged
merged 2 commits into from
Oct 9, 2022
Merged

update system variable #11505

merged 2 commits into from
Oct 9, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Oct 8, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2022
@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Oct 9, 2022
@shichun-0415 shichun-0415 self-assigned this Oct 9, 2022
shichun-0415
shichun-0415 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2022
@shichun-0415 shichun-0415 added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label Oct 9, 2022
@shichun-0415 shichun-0415 assigned TomShawn and unassigned shichun-0415 Oct 9, 2022
TomShawn
TomShawn reviewed Oct 9, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added add-missing-docs Add missing system variables, configuration items, and experimental features to documentation needs-cherry-pick-release-6.2 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 9, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Oct 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7561c7f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2022
@TomShawn TomShawn mentioned this pull request Oct 9, 2022
Merged
13 tasks
@TomShawn TomShawn merged commit 34083e5 into pingcap:master Oct 9, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11519.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11520.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11521.

ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
update system variable (#11505) (#11520)
0ca796d
ti-chi-bot added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot
update system variable (#11505) (#11519)
a9d9f06
TomShawn added a commit that referenced this pull request Oct 9, 2022
@ti-chi-bot @xiongjiwei @TomShawn
update system variable (#11505) (#11521)
1c23615 
* fix system variable doc

* Update system-variables.md

Co-authored-by: xiongjiwei <xiongjiwei1996@outlook.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
This was referenced Oct 9, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@TomShawn TomShawn TomShawn approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

@TomShawn TomShawn

Labels
add-missing-docs Add missing system variables, configuration items, and experimental features to documentation area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiongjiwei @ti-chi-bot @TomShawn @tangenta @shichun-0415