Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysvar: add 2 sysvars #10662

Merged
merged 3 commits into from
Oct 9, 2022
Merged

sysvar: add 2 sysvars #10662

merged 3 commits into from
Oct 9, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Oct 8, 2022 •
edited by shichun-0415
Loading

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

close part of #3155

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2022
TomShawn
TomShawn commented Oct 8, 2022
View reviewed changes
system-variables.md

- Scope: SESSION | GLOBAL
- Persists to cluster: Yes
- Default value: `9223372036854775807`
- Range: `[1, 9223372036854775807]`
- This variable controls the maximum number of continuous IDs to be allocated for the [`AUTO_RANDOM`](/auto-random.md) or [`SHARD_ROW_ID_BITS`](/shard-row-id-bits.md) attribute. Generally, `AUTO_RANDOM` IDs or the `SHARD_ROW_ID_BITS` annotated row IDs are incremental and continuous in one transaction. You can use this variable to solve the hotspot issue in large transaction scenarios.

### tidb_simplified_metrics
Copy link
Contributor Author

@TomShawn TomShawn Oct 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in v6.1

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. add-missing-docs Add missing system variables to documentation requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed missing-translation-status This PR does not have translation status info. labels Oct 8, 2022
@TomShawn TomShawn removed the request for review from shichun-0415 October 8, 2022 09:39
@TomShawn
Copy link
Contributor Author

TomShawn commented Oct 8, 2022

/verify

shichun-0415
shichun-0415 reviewed Oct 9, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@TomShawn @shichun-0415
Apply suggestions from code review
bf74f6e 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
shichun-0415
shichun-0415 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2022
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 9, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Oct 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 034650e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2022
@ti-chi-bot ti-chi-bot merged commit 7b828cf into pingcap:master Oct 9, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10696.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 9, 2022
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#10662
4c83594 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10697.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10698.

ti-chi-bot added a commit that referenced this pull request Oct 10, 2022
@ti-chi-bot
sysvar: add 2 sysvars (#10662) (#10697)
435d76e
ti-chi-bot added a commit that referenced this pull request Oct 10, 2022
@ti-chi-bot
sysvar: add 2 sysvars (#10662) (#10698)
6c39e98
@TomShawn TomShawn deleted the add-7-sysvars branch October 10, 2022 04:58
ti-chi-bot added a commit that referenced this pull request Oct 10, 2022
@ti-chi-bot
sysvar: add 2 sysvars (#10662) (#10696)
c9ccbca
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2022
Merged
13 tasks
ti-chi-bot added a commit to ti-chi-bot/docs that referenced this pull request Oct 10, 2022
@ti-chi-bot
sysvar: add 2 sysvars (pingcap#10662) (pingcap#10696)
90d4ce5
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2022
Merged
13 tasks
ti-chi-bot added a commit to ti-chi-bot/docs that referenced this pull request Oct 10, 2022
@ti-chi-bot
sysvar: add 2 sysvars (pingcap#10662) (pingcap#10696)
88ab98f
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2022
Merged
13 tasks
ti-chi-bot added a commit to ti-chi-bot/docs that referenced this pull request Oct 10, 2022
@ti-chi-bot
sysvar: add 2 sysvars (pingcap#10662) (pingcap#10696)
0b843c3
ti-chi-bot added a commit that referenced this pull request Oct 10, 2022
@ti-chi-bot
sysvar: add 2 sysvars (#10662) (#10696) (#10710)
e0b4191
TomShawn added a commit that referenced this pull request Oct 10, 2022
@ti-chi-bot @TomShawn
sysvar: add 2 sysvars (#10662) (#10696) (#10711)
26e07e8 
* sysvar: add 2 sysvars (#10662) (#10696)

* Update system-variables.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Oct 10, 2022
@ti-chi-bot @TomShawn
sysvar: add 2 sysvars (#10662) (#10696) (#10712)
614e4fb 
* sysvar: add 2 sysvars (#10662) (#10696)

* Update system-variables.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@shichun-0415 shichun-0415 mentioned this pull request Feb 2, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
add-missing-docs Add missing system variables to documentation needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-chi-bot @shichun-0415