Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference: fix an incorrect value, a typo, and a link #2136

Merged
merged 7 commits into from
Dec 24, 2019
Merged

reference: fix an incorrect value, a typo, and a link #2136

merged 7 commits into from
Dec 24, 2019

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Dec 24, 2019 •
edited
Loading

What is changed, added or deleted?

fix an incorrect value

What is the related PR or file link(s)?

This PR resolves three issues:

  1. To close 下降到0.00秒 #1976 (PTAL @zz-jason )
  2. To fix a typo in tidb-binlog: update docs about checkpoint & initial-commit-ts #2018 (PTAL @july2993 )
  3. To fix an incorrect link (PTAL @july2993)

Which version does your change affect?

@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. size/small Changes of a small size. labels Dec 24, 2019
@yikeke yikeke self-assigned this Dec 24, 2019
@yikeke yikeke requested a review from july2993 December 24, 2019 07:13
@yikeke yikeke changed the title reference: fix an incorrect value reference: fix an incorrect value and a typo Dec 24, 2019
july2993
july2993 reviewed Dec 24, 2019
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke changed the title reference: fix an incorrect value and a typo reference: fix an incorrect value, a typo, and a link Dec 24, 2019
lilin90
lilin90 reviewed Dec 24, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zz-jason PTAL

zz-jason
zz-jason approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilin90
lilin90 approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 8e53b98 into pingcap:master Dec 24, 2019
@cocoyi17 cocoyi17 mentioned this pull request Dec 25, 2019
Closed
@yikeke yikeke mentioned this pull request Dec 25, 2019
Merged
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 25, 2019
@yikeke yikeke deleted the fix-a-typo branch December 25, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 left review comments

@lilin90 lilin90 lilin90 approved these changes

@zz-jason zz-jason zz-jason approved these changes

Assignees

@yikeke yikeke

Labels
size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

下降到0.00秒
4 participants
@yikeke @july2993 @zz-jason @lilin90