-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb-binlog: update docs about checkpoint & initial-commit-ts #2018
Conversation
dev/reference/tidb-binlog/deploy.md
Outdated
``` | ||
|
||
该命令会输出 `meta: &{CommitTS:400962745252184065}`,CommitTS 的值作为 Drainer 初次启动使用的 `initial-commit-ts` 参数的值。 | ||
如果从最近的时间点开始同步,inital_commit_ts 使用 -1 即可。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我们默认值就是 -1,ansible 只要里只要不填写 inital_commit_ts
就可以了吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不填就是默认值,填了就填什么就什么
@july2993 如果该更新也适用于 v3.1,也请更新至 v3.1,谢谢~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments for dev
also apply to v3.0
and v3.1
.
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM. You can merge this PR after addressing these comments.
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
What is changed, added or deleted?
Update docs about checkpoint & initial-commit-ts
What is the related PR or file link(s)? <!--Write "N/A" or remove this item if it is not applicable--
relate prs:
pingcap/tidb-binlog#787
pingcap/tidb-binlog#786
Which version does your change affect?
dev, v3.1, v3.0