Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-binlog: update docs about checkpoint & initial-commit-ts #2018

Merged
merged 14 commits into from
Dec 13, 2019

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Nov 7, 2019

What is changed, added or deleted?

Update docs about checkpoint & initial-commit-ts

What is the related PR or file link(s)? <!--Write "N/A" or remove this item if it is not applicable--

relate prs:
pingcap/tidb-binlog#787
pingcap/tidb-binlog#786

Which version does your change affect?

dev, v3.1, v3.0

@july2993 july2993 requested a review from ericsyh November 7, 2019 03:17
```

该命令会输出 `meta: &{CommitTS:400962745252184065}`,CommitTS 的值作为 Drainer 初次启动使用的 `initial-commit-ts` 参数的值。
如果从最近的时间点开始同步,inital_commit_ts 使用 -1 即可。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们默认值就是 -1,ansible 只要里只要不填写 inital_commit_ts 就可以了吧?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不填就是默认值,填了就填什么就什么

@lilin90 lilin90 added DNM translation/doing This PR’s assignee is translating this PR. labels Nov 10, 2019
@TomShawn
Copy link
Contributor

TomShawn commented Nov 11, 2019

@july2993 如果该更新也适用于 v3.1,也请更新至 v3.1,谢谢~

@july2993
Copy link
Contributor Author

july2993 commented Dec 5, 2019

@TomShawn @ericsyh PTAL

@july2993 july2993 requested a review from suzaku December 5, 2019 09:39
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn changed the title Update docs about checkpoint & initial-commit-ts tidb-binlog: update docs about checkpoint & initial-commit-ts Dec 6, 2019
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments for dev also apply to v3.0 and v3.1.

dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
v3.0/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
v3.0/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
v3.0/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
v3.0/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
v3.1/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
@july2993
Copy link
Contributor Author

@TomShawn PTAL

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. You can merge this PR after addressing these comments.

dev/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
v3.0/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
v3.1/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
v3.1/reference/tidb-binlog/deploy.md Outdated Show resolved Hide resolved
july2993 and others added 2 commits December 13, 2019 22:50
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@july2993 july2993 merged commit f598324 into pingcap:master Dec 13, 2019
@july2993 july2993 deleted the checkpoint_init branch December 13, 2019 14:55
@lilin90 lilin90 removed the DNM label Dec 17, 2019
@lilin90 lilin90 added the size/small Changes of a small size. label Dec 17, 2019
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants