Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: update explain results (#2548) #2865

Merged
merged 2 commits into from
Apr 23, 2020
Merged

sql: update explain results (#2548) #2865

merged 2 commits into from
Apr 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 22, 2020

cherry-pick #2548 to release-4.0

What is changed, added or deleted? (Required)

Update statement of EXPLAIN with tidb-in-action.

Update explain result with current result.

Which TiDB version(s) do your changes apply to? (Required)

master

What is the related PR or file link(s)?

@LittleFall @ran-huang @sre-bot
sql: update explain results (pingcap#2548)
c737a75 
* Modify explain result.

* Update with tidb-in-action.

* Reorder statements.

* Fix multi \n bug.

* Apply suggestions from code review

Co-Authored-By: Ran <huangran@pingcap.com>

* Refine some typo.

* Refine article structure.

* Remove useless "`".

* Update reference/sql/statements/explain.md

Co-Authored-By: Ran <huangran@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@sre-bot sre-bot mentioned this pull request Apr 22, 2020
Merged
@sre-bot sre-bot added size/large Changes of a large size. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Apr 22, 2020
zz-jason
zz-jason reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2020
lzmhhh123
lzmhhh123 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2020
@ran-huang ran-huang added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Apr 23, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

/run-all-tests

@sre-bot sre-bot merged commit 555d414 into pingcap:release-4.0 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@ran-huang ran-huang ran-huang approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees

@LittleFall LittleFall

Labels
size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @zz-jason @lzmhhh123 @ran-huang @LittleFall