Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Refine Explain's format. #15507

Merged
merged 57 commits into from
Mar 23, 2020
Merged

*: Refine Explain's format. #15507

merged 57 commits into from
Mar 23, 2020

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Mar 20, 2020

What problem does this PR solve?

Problem Summary:

  • For EXPLAIN and EXPLAIN ANALYZE, add column access object after column task, it includes table name or index name.
  • Reorder EXPLAIN and EXPLAIN ANALYZE columns.
  • Add build and probe side display for index merge operator in EXPLAIN.
  • Show index name(besides index columns) in EXPLAIN.
  • Fix unexpected _0 bug.
  • Unify HashLeftJoin and HashRightJoin to HashJoin.

What is changed and how it works?

Add new interface dataAccesser, which means it can access underlying data.
PhysicalTableScan, PhysicalIndexScan, PointGetPlan, BatchPointScan and PhysicalMemTable implements it, so that they can get their AccessObject.

Check List

Tests

  • Unit test
  • Integration test
  • No code

Release note

  • For EXPLAIN and EXPLAIN ANALYZE, add column access object after column task, it includes table name or index name.
  • Reorder EXPLAIN and EXPLAIN ANALYZE columns.
  • Add build and probe side display for index merge operator in EXPLAIN.
  • Show index name(besides index columns) in EXPLAIN.
  • Fix unexpected _0 bug.
  • Unify HashLeftJoin and HashRightJoin to HashJoin.

LittleFall and others added 30 commits February 19, 2020 08:14
*: show build and probe side for join and index lookup related operat…
@LittleFall
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1007

1 similar comment
@LittleFall
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1007

@LittleFall
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1007

1 similar comment
@LittleFall
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1007

@LittleFall
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1007

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LittleFall
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1007

@LittleFall
Copy link
Contributor Author

/run-unit-test tidb-test=pr/1007

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LittleFall
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1007

@lzmhhh123
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 23, 2020

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement. type/usability
Projects
None yet
5 participants