Add explaination about tidb_allow_batch_cop #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
added
status/PTAL
|
@JaySon-Huang 这个 PR 是否为 docs-special-week 的 PR 呢？如果是，请将 branch rebase 到 docs-special-week。 |
|
@TomShawn 有一个新功能开发完，在4.0GA会带出去，但是之前没有补充相关的文档说明。没有在 special-week 原计划内。 |
TomShawn
reviewed
May 22, 2020
tiflash/tune-tiflash-performance.md
Outdated
| @@ -22,10 +22,30 @@ aliases: ['/docs-cn/dev/reference/tiflash/tune-performance/'] | |||
| set @@tidb_distsql_scan_concurrency = 80; | |||
| ``` | |||
|
|
|||
| 2. 开启聚合推过 JOIN / UNION 等 TiDB 算子的优化： | |||
| 2. 开启 Super batch 功能： | |||
| 这个变量用来设置从 TiFlash 读取时，是否把 region 的请求进行合并。当查询中涉及的 region 数量比较大，可以尝试设置该变量为 1：对带 aggregation 的 TiFlash coprocess 请求生效；设置该变量为 2：对全部的 TiFlash coprocessor 请求生效。 | |||
There was a problem hiding this comment.
这个变量是什么变量呢？请明确写出变量名，最好能附上tidb-specific-system-variables.md里的链接。- region 的首字母为大写。
tiflash/tune-tiflash-performance.md
Outdated
|
|
||
| {{< copyable "sql" >}} | ||
|
|
||
| ```sql | ||
| set @@tidb_opt_agg_push_down = 1; | ||
| ``` | ||
|
|
||
| 4. 尝试开启 `Distince` 推过 `Join` / `Union` 等 TiDB 算子的优化： | ||
| 这个变量用来设置优化器是否执行带有 `Distinct` 的聚合函数（比如 `select count(distinct a) from t`）下推到 Coprocessor 的优化操作。 |
There was a problem hiding this comment.
这个变量是什么变量呢？请明确写出变量名，最好能附上 tidb-specific-system-variables.md 里的链接。
tiflash/tune-tiflash-performance.md
Outdated
|
|
||
| 4. 尝试开启 `Distince` 推过 `Join` / `Union` 等 TiDB 算子的优化： | ||
| 这个变量用来设置优化器是否执行带有 `Distinct` 的聚合函数（比如 `select count(distinct a) from t`）下推到 Coprocessor 的优化操作。 | ||
| 当查询中带有 `Distinct` 的聚合操作执行很慢时，可以尝试设置该变量为 `1`。 |
There was a problem hiding this comment.
如需换行，请在两行之间插入空行，否则会显示无换行。
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
@TomShawn, @hanfei1991, PTAL. |
hanfei1991
reviewed
May 25, 2020
JaySon-Huang
commented
May 25, 2020
|
LGTM |
yikeke
approved these changes
May 26, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
yikeke
reviewed
May 27, 2020
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
May 29, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
5 tasks
|
cherry pick to release-4.0 in PR #3403 |
yikeke
pushed a commit
that referenced
this pull request
May 29, 2020
5 tasks
yikeke
added
translation/done
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang tshent@qq.com
What is changed, added or deleted? (Required)
Add explaination about a new system variable
tidb_allow_batch_copto tidb-specific-variables.md and tiflash/tune-tiflash-performance.mdWhich TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?