-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx/variable: open batch_cop for tiflash by default (#18190) #18552
sessionctx/variable: open batch_cop for tiflash by default (#18190) #18552
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
cherry-pick #18190 to release-4.0
What problem does this PR solve?
Open tidb_allow_batch_cop by default and test report is https://docs.google.com/document/d/1uZqfNWwha4317sMGF92R2xovJAZCV1EWSIjhrVd0BB0/edit
Problem Summary:
batch cop is added by #16030 and its doc is pingcap/docs-cn#3265
After POC for a long time, we decide to open this feature by default.
What's Changed:
Only a default value for variable is changed.
Side effects
Release note
active tidb_allow_batch_cop by default.