Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql-statements: improve SHOW TABLE REGIONS examples #4311

Merged
merged 5 commits into from
Aug 26, 2020

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Aug 21, 2020

What is changed, added or deleted? (Required)

update examples and a section to make features of the syntax clearer.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, translation/from-docs, status/PTAL

@ti-srebot ti-srebot added needs-cherry-pick-3.1 status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Aug 21, 2020
@Joyinqin
Copy link
Contributor Author

/cc TomShawn, bb7133

@ti-srebot
Copy link
Contributor

@bb7133, @TomShawn, PTAL.

sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@TomShawn, @bb7133, PTAL.

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Aug 26, 2020
Joyinqin and others added 2 commits August 26, 2020 18:15
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin
Copy link
Contributor Author

/cc imtbkcat

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
@TomShawn TomShawn merged commit 56c05bc into pingcap:master Aug 26, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #4348

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4349

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4350

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4351

TomShawn pushed a commit that referenced this pull request Aug 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@Joyinqin Joyinqin deleted the sql-2 branch August 26, 2020 11:38
TomShawn pushed a commit that referenced this pull request Aug 28, 2020
* cherry pick #4311 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update sql-statement-show-table-regions.md

* Update sql-statement-show-table-regions.md

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Aug 28, 2020
* cherry pick #4311 to release-2.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Delete sql-statement-show-table-regions.md

* Delete sql-statement-split-region.md

* Update TOC.md

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
ti-srebot added a commit that referenced this pull request Aug 28, 2020
* cherry pick #4311 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update sql-statement-show-table-regions.md

* Update sql-statement-show-table-regions.md

* Update sql-statements/sql-statement-show-table-regions.md

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants