Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-statements: improve SHOW TABLE REGIONS examples #3389

Merged
merged 8 commits into from Jul 23, 2020
Merged

sql-statements: improve SHOW TABLE REGIONS examples #3389

merged 8 commits into from Jul 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2020

What is changed, added or deleted? (Required)

The examples in SHOW TABLE REGIONS were not paste-reproducible with multiple regions included. This makes it a bit harder for users to understand how these features work.

I have rewritten the first example, and added a section at the bottom to show this is an extension to MySQL syntax.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

yikeke
yikeke reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions for style unification:

  1. region -> Region
  2. Use the present tense when possible.

Rest LGTM

sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-table-regions.md Outdated Show resolved Hide resolved
@yikeke yikeke requested a review from zz-jason July 23, 2020 00:46
@yikeke yikeke added status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Jul 23, 2020
Null not nil and others added 6 commits July 22, 2020 21:00
@yikeke
Update sql-statements/sql-statement-show-table-regions.md
35ba835 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke
Update sql-statements/sql-statement-show-table-regions.md
89ec9c4 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke
Update sql-statements/sql-statement-show-table-regions.md
ee8a879 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke
Update sql-statements/sql-statement-show-table-regions.md
40d5f12 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke
Update sql-statements/sql-statement-show-table-regions.md
844d575 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke
Update sql-statements/sql-statement-show-table-regions.md
d6a16c4 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
zz-jason
zz-jason approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2020
yikeke
yikeke approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 23, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 23, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit c5acf0a into pingcap:master Jul 23, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 23, 2020
@ti-srebot
cherry pick pingcap#3389 to release-2.1
c4db833 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3396

@ti-srebot ti-srebot mentioned this pull request Jul 23, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3397

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 23, 2020
@ti-srebot
cherry pick pingcap#3389 to release-3.1
1714083 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3398

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 23, 2020
@ti-srebot
cherry pick pingcap#3389 to release-4.0
0e452c5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 23, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3399

lilin90 pushed a commit that referenced this pull request Jul 23, 2020
@ti-srebot
cherry pick #3389 to release-3.0 (#3397)
4483f21 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
lilin90 pushed a commit that referenced this pull request Jul 23, 2020
@ti-srebot
cherry pick #3389 to release-4.0 (#3399)
c306341 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
lilin90 pushed a commit that referenced this pull request Jul 23, 2020
@ti-srebot
cherry pick #3389 to release-3.1 (#3398)
ca71b7e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
yikeke pushed a commit that referenced this pull request Jul 24, 2020
@ti-srebot
sql-statements: improve SHOW TABLE REGIONS examples (#3389) (#3396)
e040318 
* cherry pick #3389 to release-2.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Delete sql-statement-show-table-regions.md

* Delete sql-statement-split-region.md

* Update TOC.md

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
@yikeke yikeke assigned Joyinqin and unassigned ireneontheway Jul 28, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 11, 2020
Closed
9 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 11, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Aug 11, 2020
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Aug 20, 2020
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 21, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Aug 21, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 21, 2020
Merged
9 tasks
This was referenced Aug 26, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Joyinqin Joyinqin

Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yikeke @ti-srebot @Joyinqin @zz-jason @TomShawn @ireneontheway