Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd: add new configurations #5153

Merged
merged 4 commits into from
Dec 23, 2020
Merged

pd: add new configurations #5153

merged 4 commits into from
Dec 23, 2020

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

We have added a new configuration region-score-formula-version and updated the default value of enable-cross-table-merge for v5.0.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@disksing
pd: add new configurations
4e6440e 
Signed-off-by: disksing <i@disksing.com>
@TomShawn TomShawn self-assigned this Dec 23, 2020
@TomShawn TomShawn added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. v5.0 This PR/issue applies to TiDB v5.0 labels Dec 23, 2020
@ti-srebot
Copy link
Contributor

@lhy1024, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn reviewed Dec 23, 2020
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Dec 23, 2020
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2020
@TomShawn TomShawn merged commit 62d39ad into pingcap:master Dec 23, 2020
@TomShawn TomShawn added the requires-followup This PR requires a follow-up task after being merged. label Dec 23, 2020
@TomShawn
Copy link
Contributor

Follow-up: 添加引入版本的标记

@TomShawn TomShawn assigned CharLotteiu and unassigned TomShawn Dec 23, 2020
@CharLotteiu CharLotteiu mentioned this pull request Dec 23, 2020
Merged
9 tasks
@CharLotteiu CharLotteiu added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees

@CharLotteiu CharLotteiu

Labels
requires-followup This PR requires a follow-up task after being merged. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@disksing @ti-srebot @TomShawn @lhy1024 @CharLotteiu