Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: enable cross table merge by default #3129

Merged
merged 4 commits into from
Nov 6, 2020
Merged

config: enable cross table merge by default #3129

merged 4 commits into from
Nov 6, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 2, 2020

What problem does this PR solve?

See https://docs.google.com/document/d/1KKVGJMOY6gmuVrVwqGiA2p0sQL5YqF2zoDbqNSgAhKg/edit#

What is changed and how it works?

This PR enables cross table merge by default.

Check List

Tests

  • Unit test

Release note

@rleungx
enable merge cross table by default
666e4df 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the component/config Configuration logic. label Nov 2, 2020
HunDunDM
HunDunDM approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2020
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2020
@ti-chi-bot
Copy link
Member

@ti-srebot: adding LGTM is restricted to reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@lhy1024
Copy link
Contributor

lhy1024 commented Nov 2, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2020
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Nov 2, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2020
@ti-srebot
Copy link
Contributor

@ti-community-prow-bot Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: scheduling(slack).

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@Rustin170506
Copy link
Member

/rebase

nolouch
nolouch reviewed Nov 2, 2020
View reviewed changes
server/config/config.go
@@ -802,6 +803,9 @@ func (c *ScheduleConfig) adjust(meta *configMetaData) error {
if !meta.IsDefined("enable-joint-consensus") {
c.EnableJointConsensus = defaultEnableJointConsensus
}
if !meta.IsDefined("enable-cross-table-merge") {
c.EnableCrossTableMerge = defaultEnableCrossTableMerge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we let the merge is enabled if an upgrade from 4.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends, do you think it's better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some paraments should be adjusted to a better default value, even it is upgraded from old version. such as tolerance-ratio

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, but maybe in another PR?

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2020
@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: f03bbae

@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/run-all-tests

@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2020

/run-integration-ddl-test

@rleungx
Copy link
Member Author

rleungx commented Nov 6, 2020

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit b77c843 into tikv:master Nov 6, 2020
@overvenus overvenus mentioned this pull request Nov 20, 2020
Closed
@nolouch nolouch mentioned this pull request Dec 16, 2020
Closed
@disksing disksing mentioned this pull request Dec 22, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
component/config Configuration logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rleungx @ti-chi-bot @lhy1024 @ti-srebot @Rustin170506 @HunDunDM @nolouch