Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add doc for start-task --start-time #8640

Merged
merged 6 commits into from
Mar 17, 2022
Merged

add doc for start-task --start-time #8640

merged 6 commits into from
Mar 17, 2022

Conversation

lance6716
Copy link
Contributor

What is changed, added or deleted? (Required)

as title

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2022
@lance6716
Copy link
Contributor Author

/cc @sunzhaoyang @ran-huang

@ran-huang ran-huang added v6.0 This PR/issue applies to TiDB v6.0. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 14, 2022
ran-huang
ran-huang reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec 里提到的这个部分，文档里要体现出来吗？

任务开始时将会有三个起始点：

配置文件中指定的位置
checkpoint 记录的位置
start-task --start-time 指定的时间对应的位置

三个起始点如何选择，应该有文档进行明确说明；命令执行时也应该有所提示，明确的告知用户。

dm/dm-create-task.md Outdated Show resolved Hide resolved
@lance6716
Copy link
Contributor Author

spec 里提到的这个部分，文档里要体现出来吗？

任务开始时将会有三个起始点：

配置文件中指定的位置
checkpoint 记录的位置
start-task --start-time 指定的时间对应的位置

三个起始点如何选择，应该有文档进行明确说明；命令执行时也应该有所提示，明确的告知用户。

updated, PTAL

@ran-huang ran-huang self-assigned this Mar 16, 2022
@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label Mar 16, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 16, 2022
@TomShawn TomShawn removed their request for review March 17, 2022 02:27
ran-huang
ran-huang approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
sunzhaoyang
sunzhaoyang reviewed Mar 17, 2022
View reviewed changes
dm/dm-create-task.md
- 当该任务存在 checkpoint 时，如果通过这种方式启动任务，DM 会自动开启 safe mode 直到同步过 checkpoint，以避免重置任务到更早位置时遇到数据重复的报错
- 格式为 `'2021-10-21 00:01:00'` 或 `2021-10-21T00:01:00`
- 指定了过早的时间时，会从最早的 binlog 开始同步
- 指定了过晚的时间时，会报错 `start-time {input-time} is too late, no binlog location matches it`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lance6716 我记得设计的时候说还有个限制，指定过一次时间后，就不能再次指定一个 later 的时间了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊，这一个选项的注意事项好长啊……

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4ca1f01

sunzhaoyang
sunzhaoyang approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@sunzhaoyang sunzhaoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

ran-huang
ran-huang reviewed Mar 17, 2022
View reviewed changes
dm/dm-create-task.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@ran-huang: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
@ran-huang
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 853a8d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@ti-chi-bot ti-chi-bot merged commit e861358 into master Mar 17, 2022
@ran-huang ran-huang removed the translation/doing This PR’s assignee is translating this PR. label Mar 17, 2022
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Mar 17, 2022
@ran-huang ran-huang added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 17, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 17, 2022
@ran-huang ran-huang deleted the lance6716-patch-5 branch March 17, 2022 08:55
@ran-huang ran-huang mentioned this pull request Mar 17, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@sunzhaoyang sunzhaoyang sunzhaoyang approved these changes

Assignees

@ran-huang ran-huang

Labels
area/dm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @ti-chi-bot @ran-huang @sunzhaoyang @TomShawn