syncer(dm): implement start-task --start-time #4485

lance6716 · 2022-01-26T09:11:03Z

What problem does this PR solve?

Issue Number: close #4106

What is changed and how it works?

continue on previous PRs, now syncer of DM worker should first find the corresponding binlog location of --start-time, clean outdated checkpoints and save it to global checkpoint. After the first time global checkpoint is flushed, DM worker also tries to clean the task command line arguments saved in etcd.

Check List

Tests

Integration test

Code changes

Has interface methods change

Side effects

Related changes

Release note

Support start-task with `--start-time`.

ti-chi-bot · 2022-01-26T09:11:04Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

D3Hunter
Ehco1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov-commenter · 2022-01-26T12:04:15Z

Codecov Report

Merging #4485 (715b434) into master (9607554) will decrease coverage by 0.1286%.
The diff coverage is 59.6401%.

Flag	Coverage Δ
cdc	`60.3071% <59.3750%> (+0.3849%)`	⬆️
dm	`51.4451% <59.7194%> (-0.5838%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4485        +/-   ##
================================================
- Coverage   55.6402%   55.5116%   -0.1287%     
================================================
  Files           494        506        +12     
  Lines         61283      62722      +1439     
================================================
+ Hits          34098      34818       +720     
- Misses        23750      24430       +680     
- Partials       3435       3474        +39

lance6716 · 2022-01-27T06:19:33Z

/cc @D3Hunter

lance6716 · 2022-01-27T06:23:26Z

/run-dm-integration-test

Ehco1996 · 2022-02-08T02:10:25Z

dm/syncer/syncer.go

-	if err != nil {
-		return err
+	if s.cfg.Meta == nil || s.cfg.Meta.BinLogName != binlog.FakeBinlogName {
+		err = s.setInitActiveRelayLog(ctx)


seems setInitActiveRelayLog can move to sync.Run so that we don't need this check s.cfg.Meta.BinLogName != binlog.FakeBinlogName ?

when Init syncer, set active relay log info

we will risk the relay log being purged between Init and Run. I prefer we don't change old logic if we don't have enough thinking.

but if we into this branch s.cfg.Meta.BinLogName != binlog.FakeBinlogName user still have this risk

so how about make setInitActiveRelayLog support set binlog user want to start in s.Init ? i mean call binlog finder in init

Init should not have long-running tasks by definition, it will cause whole pipeline timeout.

dm/syncer/syncer.go

GMHDBJD · 2022-02-10T06:15:47Z

dm/dm/master/server.go

 		}
+		err = cfg.Adjust()
+	} else {
+		err = cfg.Decode(task)
 	}


Can we set inst.Meta after cfg.Decode? So we no need RawDecode and Adjust, only depend on cfg.Decode.

cfg.Decode will call adjust internally, then it will report error about inst.Meta.

GMHDBJD · 2022-02-10T06:19:26Z

dm/syncer/checkpoint.go

+
+	cp.logCtx.L().Info("delete all table checkpoint")
+	_, err := cp.dbConn.ExecuteSQL(
+		tctx,


Should we use maxDMLConnectionDuration or defaultDBTimeout?

GMHDBJD · 2022-02-10T06:25:42Z

dm/syncer/syncer.go

+			zap.String("time", timeStr),
+			zap.Stringer("pos", loc))
+	case binlog.BelowLowerBoundBinlogPos:
+		s.tctx.L().Warn("fail to find binlog location by timestamp because the timestamp is too early, will use the earliest binlog location",


Will return error better?

cc @sunzhaoyang

GMHDBJD · 2022-02-10T06:28:57Z

dm/tests/start_task/run.sh

+
+	run_dm_ctl $WORK_DIR "127.0.0.1:$MASTER_PORT" \
+		"stop-task test" \
+		"\"result\": true" 2


How about triger a worker transfer event here?

GMHDBJD · 2022-02-10T06:47:53Z

dm/syncer/syncer.go

+	if s.cliArgs != nil && s.cliArgs.StartTime != "" {
+		clone := *s.cliArgs
+		clone.StartTime = ""
+		err2 := ha.PutTaskCliArgs(s.cli, s.cfg.Name, []string{s.cfg.SourceID}, clone)


Why not use DelTaskCliBySource?

we might have more args in near future, so for compatible I should only remove the least argument.

D3Hunter

will review test later.

dm/pkg/binlog/pos_finder.go

dm/syncer/checkpoint.go

dm/syncer/syncer.go

Ehco1996

will review test later

Co-authored-by: D3Hunter <jujj603@gmail.com>

Ehco1996

restLGTM

dm/syncer/checkpoint.go

dm/tests/start_task/run.sh

D3Hunter

LGTM

Ehco1996

LGTM

lance6716 · 2022-02-14T05:01:43Z

/merge

ti-chi-bot · 2022-02-14T05:01:45Z

This pull request has been accepted and is ready to merge.

Commit hash: 71a9cda

lance6716 · 2022-02-14T07:12:40Z

/run-verify

lance6716 · 2022-02-14T07:42:29Z

/merge

ti-chi-bot · 2022-02-14T07:42:31Z

This pull request has been accepted and is ready to merge.

Commit hash: 3ba5edd

lance6716 · 2022-02-14T08:32:37Z

/merge

lance6716 · 2022-02-14T09:26:41Z

/run-verify

lance6716 · 2022-02-14T09:26:51Z

/merge

ti-chi-bot · 2022-02-14T09:26:57Z

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close pingcap#4106

syncer(dm): implement start-task --start-time

85de7de

lance6716 added the area/dm Issues or PRs related to DM. label Jan 26, 2022

add some IT

43cc6f0

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2022

lance6716 added 2 commits January 27, 2022 11:41

save work

5ef486d

add more IT

c669736

lance6716 changed the title ~~[WIP] syncer(dm): implement start-task --start-time~~ syncer(dm): implement start-task --start-time Jan 27, 2022

ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2022

ti-chi-bot requested a review from D3Hunter January 27, 2022 06:19

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2022

Merge branch 'master' of github.com:pingcap/ticdc into start-time-2

3799496

ti-chi-bot added do-not-merge/needs-triage-completed and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 8, 2022

Ehco1996 reviewed Feb 8, 2022

View reviewed changes

address comment

c61d696

ti-chi-bot removed the do-not-merge/needs-triage-completed label Feb 8, 2022

GMHDBJD reviewed Feb 10, 2022

View reviewed changes

D3Hunter reviewed Feb 10, 2022

View reviewed changes

dm/pkg/binlog/pos_finder.go Outdated Show resolved Hide resolved

dm/syncer/checkpoint.go Outdated Show resolved Hide resolved

dm/syncer/syncer.go Show resolved Hide resolved

Ehco1996 reviewed Feb 10, 2022

View reviewed changes

Update dm/pkg/binlog/pos_finder.go

d790138

Co-authored-by: D3Hunter <jujj603@gmail.com>

Ehco1996 reviewed Feb 14, 2022

View reviewed changes

dm/syncer/checkpoint.go Outdated Show resolved Hide resolved

dm/tests/start_task/run.sh Show resolved Hide resolved

dm/tests/start_task/run.sh Show resolved Hide resolved

dm/tests/start_task/run.sh Outdated Show resolved Hide resolved

lance6716 added 2 commits February 14, 2022 11:02

address comment

ae472da

Merge branch 'master' into start-time-2

71a9cda

D3Hunter approved these changes Feb 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2022

Ehco1996 approved these changes Feb 14, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022

Merge branch 'master' of github.com:pingcap/ticdc into start-time-2

3ba5edd

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022

Merge branch 'master' into start-time-2

eed3ec1

Merge branch 'master' into start-time-2

715b434

ti-chi-bot merged commit 803aa92 into pingcap:master Feb 14, 2022

zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022

syncer(dm): implement start-task --start-time (pingcap#4485)

4974552

close pingcap#4106

lance6716 mentioned this pull request Mar 14, 2022

add doc for start-task --start-time pingcap/docs-cn#8640

Merged

15 tasks

lance6716 deleted the start-time-2 branch October 13, 2022 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

syncer(dm): implement start-task --start-time #4485

syncer(dm): implement start-task --start-time #4485

lance6716 commented Jan 26, 2022 •

edited

Loading

ti-chi-bot commented Jan 26, 2022 •

edited

Loading

codecov-commenter commented Jan 26, 2022 •

edited

Loading

lance6716 commented Jan 27, 2022

lance6716 commented Jan 27, 2022

Ehco1996 Feb 8, 2022

lance6716 Feb 8, 2022

Ehco1996 Feb 10, 2022

lance6716 Feb 14, 2022

GMHDBJD Feb 10, 2022

lance6716 Feb 14, 2022

GMHDBJD Feb 10, 2022

GMHDBJD Feb 10, 2022

lance6716 Feb 13, 2022

GMHDBJD Feb 10, 2022

GMHDBJD Feb 10, 2022

lance6716 Feb 13, 2022

D3Hunter left a comment

Ehco1996 left a comment

Ehco1996 left a comment

D3Hunter left a comment

Ehco1996 left a comment

lance6716 commented Feb 14, 2022

ti-chi-bot commented Feb 14, 2022

lance6716 commented Feb 14, 2022

lance6716 commented Feb 14, 2022

ti-chi-bot commented Feb 14, 2022

lance6716 commented Feb 14, 2022

lance6716 commented Feb 14, 2022

lance6716 commented Feb 14, 2022

ti-chi-bot commented Feb 14, 2022

syncer(dm): implement start-task --start-time #4485

syncer(dm): implement start-task --start-time #4485

Conversation

lance6716 commented Jan 26, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jan 26, 2022 • edited Loading

codecov-commenter commented Jan 26, 2022 • edited Loading

Codecov Report

lance6716 commented Jan 27, 2022

lance6716 commented Jan 27, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

D3Hunter left a comment

Choose a reason for hiding this comment

Ehco1996 left a comment

Choose a reason for hiding this comment

Ehco1996 left a comment

Choose a reason for hiding this comment

D3Hunter left a comment

Choose a reason for hiding this comment

Ehco1996 left a comment

Choose a reason for hiding this comment

lance6716 commented Feb 14, 2022

ti-chi-bot commented Feb 14, 2022

lance6716 commented Feb 14, 2022

lance6716 commented Feb 14, 2022

ti-chi-bot commented Feb 14, 2022

lance6716 commented Feb 14, 2022

lance6716 commented Feb 14, 2022

lance6716 commented Feb 14, 2022

ti-chi-bot commented Feb 14, 2022

lance6716 commented Jan 26, 2022 •

edited

Loading

ti-chi-bot commented Jan 26, 2022 •

edited

Loading

codecov-commenter commented Jan 26, 2022 •

edited

Loading