Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh, en: modify format of --advertise-peer-urls (master) #323

Merged
merged 2 commits into from
Aug 31, 2020
Merged

zh, en: modify format of --advertise-peer-urls (master) #323

merged 2 commits into from
Aug 31, 2020

Conversation

lance6716
Copy link
Contributor

What is changed, added or deleted? (Required)

modify format of --advertise-peer-urls to align with pingcap/dm#955

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

csuzhangxc
csuzhangxc reviewed Aug 31, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
yikeke
yikeke approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 31, 2020
@yikeke yikeke added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. translation/no-need The changes in this PR don't need to be translated. labels Aug 31, 2020
@yikeke yikeke merged commit e219be1 into pingcap:master Aug 31, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Sep 8, 2020

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Sep 8, 2020
@lance6716 @ti-srebot
cherry pick pingcap#323 to release-2.0
abf0652 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #361

TomShawn pushed a commit that referenced this pull request Sep 8, 2020
@ti-srebot @lance6716
cherry pick #323 to release-2.0 (#361)
11c9405 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @TomShawn @ti-srebot @csuzhangxc @yikeke