Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh, en: modify format of --advertise-peer-urls (master) (#323) #361

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #323 to release-2.0


What is changed, added or deleted? (Required)

modify format of --advertise-peer-urls to align with pingcap/dm#955

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added the type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR. label Sep 8, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2020
@TomShawn TomShawn merged commit 11c9405 into pingcap:release-2.0 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-2.0 This PR is cherry-picked to release-2.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants