Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: some mirror updates #379

Merged
merged 3 commits into from
Sep 15, 2020
Merged

zh: some mirror updates #379

merged 3 commits into from
Sep 15, 2020

Conversation

csuzhangxc
Copy link
Member

What is changed, added or deleted? (Required)

  • update some links to MySQL docs because slave has been updated
  • add more explanation about HA
  • add max-allowed-packet into task config sample
  • mirror updates the format about TiUP doc

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@@ -42,6 +42,7 @@ target-database: # 下游数据库实例配置
port: 4000
user: "root"
password: "/Q7B9DizNLLTTfiZHv9WoEAKamfpIUs=" # 推荐使用经 dmctl 加密后的密码
max-allowed-packet: 67108864 # 设置 DM 内部连接 TiDB 时客户端的 "max_allowed_packet" 限制,单位为字节,默认 67108864 (64 MB)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed after implemented pingcap/dm#1003.

@csuzhangxc
Copy link
Member Author

@lance6716 @ireneontheway PTAL

@lance6716
Copy link
Contributor

LGTM

@ti-srebot
Copy link
Contributor

@lance6716,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@ireneontheway ireneontheway self-assigned this Sep 13, 2020
@ireneontheway ireneontheway added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Sep 13, 2020
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2020
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 15, 2020
@yikeke
Copy link
Contributor

yikeke commented Sep 15, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit e3d7463 into pingcap:master Sep 15, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Sep 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 15, 2020
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #388

yikeke pushed a commit that referenced this pull request Sep 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
@ireneontheway ireneontheway added translation/done This PR has been translated. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 17, 2020
@ireneontheway ireneontheway mentioned this pull request Sep 17, 2020
7 tasks
@ti-srebot ti-srebot mentioned this pull request Sep 21, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants