Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en: some mirror updates #392

Merged
merged 3 commits into from
Sep 21, 2020
Merged

en: some mirror updates #392

merged 3 commits into from
Sep 21, 2020

Conversation

ireneontheway
Copy link
Contributor

What is changed, added or deleted? (Required)

  • update some links to MySQL docs because slave has been updated
  • add more explanation about HA
  • add max-allowed-packet into task config sample
  • mirror updates the format about TiUP doc

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@ireneontheway ireneontheway added status/PTAL This PR is ready for reviewing. translation/from-zh This PR is translated from a PR in docs-dm/zh. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. labels Sep 17, 2020
yikeke
yikeke reviewed Sep 18, 2020
View reviewed changes
en/glossary.md Outdated Show resolved Hide resolved
en/key-features.md Outdated Show resolved Hide resolved
en/overview.md Outdated Show resolved Hide resolved
en/overview.md Outdated Show resolved Hide resolved
en/task-configuration-file-full.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@yikeke, @csuzhangxc, PTAL.

@ireneontheway @yikeke
Apply suggestions from code review
b2e0298 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke
yikeke approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2020
csuzhangxc
csuzhangxc reviewed Sep 21, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 21, 2020
@yikeke yikeke merged commit 0c60c88 into pingcap:master Sep 21, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Sep 21, 2020
@ireneontheway @ti-srebot
cherry pick pingcap#392 to release-2.0
5c99b0c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 21, 2020
Merged
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #394

yikeke pushed a commit that referenced this pull request Sep 21, 2020
@ti-srebot @ireneontheway
cherry pick #392 to release-2.0 (#394)
635da5d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-zh This PR is translated from a PR in docs-dm/zh.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ireneontheway @ti-srebot @csuzhangxc @yikeke