Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en: update safe mode description #454

Merged
merged 2 commits into from
Oct 29, 2020
Merged

en: update safe mode description #454

merged 2 commits into from
Oct 29, 2020

Conversation

CharLotteiu
Copy link
Contributor

What is changed, added or deleted? (Required)

Add some description about "safe mode".

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts after cherry-picked

@CharLotteiu CharLotteiu added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/PTAL This PR is ready for reviewing. translation/from-zh This PR is translated from a PR in docs-dm/zh. labels Oct 29, 2020
yikeke
yikeke reviewed Oct 29, 2020
View reviewed changes
en/glossary.md Outdated Show resolved Hide resolved
en/glossary.md Outdated Show resolved Hide resolved
en/glossary.md Outdated Show resolved Hide resolved
@yikeke
Copy link
Contributor

yikeke commented Oct 29, 2020

Rest LGTM

lance6716
lance6716 reviewed Oct 29, 2020
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

en/glossary.md Outdated Show resolved Hide resolved
@CharLotteiu @yikeke
Apply suggestions from code review
b5d7e15 
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke
yikeke approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2020
@yikeke yikeke merged commit 1f3da4d into pingcap:master Oct 29, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Oct 29, 2020
@CharLotteiu @ti-srebot
cherry pick pingcap#454 to release-2.0
0cccabc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 29, 2020
Merged
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #455

yikeke pushed a commit that referenced this pull request Oct 29, 2020
@ti-srebot @CharLotteiu
cherry pick #454 to release-2.0 (#455)
0989efc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
@CharLotteiu CharLotteiu mentioned this pull request Oct 29, 2020
Merged
7 tasks
This was referenced Oct 30, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-zh This PR is translated from a PR in docs-dm/zh.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharLotteiu @yikeke @ti-srebot @lance6716