Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-lightning: update docs #2946

Merged
merged 4 commits into from
Jun 23, 2020
Merged

tidb-lightning: update docs #2946

merged 4 commits into from
Jun 23, 2020

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Jun 17, 2020

What is changed, added or deleted? (Required)

Incorporate changes for these new features since last time:

  • TLS config
  • TiKV Importer now supports listening on 0.0.0.0
  • TiKV Importer no longer requires Pushgateway for Prometheus
  • CSV strict-format config for optional parallel speed up
  • TiDB's default SQL mode is no longer strict
  • Several new CLI parameters are exposed

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@kennytm kennytm added size/medium Changes of a medium size. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Jun 17, 2020
@github-actions github-actions bot requested a review from yikeke June 17, 2020 20:07
yikeke
yikeke reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL @WangXiangUSTC

@yikeke yikeke added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 19, 2020
@ti-srebot
Copy link
Contributor

@yikeke, @WangXiangUSTC, @3pointer, PTAL.

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 22, 2020
kissmydb
kissmydb approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yikeke
Copy link
Contributor

yikeke commented Jun 22, 2020

PTAL @3pointer

@yikeke yikeke added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. labels Jun 22, 2020
3pointer
3pointer reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 23, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 974440a into master Jun 23, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 23, 2020
@kennytm @ti-srebot
cherry pick pingcap#2946 to release-4.0
5c10079 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2994

yikeke pushed a commit that referenced this pull request Jun 23, 2020
@ti-srebot @kennytm
cherry pick #2946 to release-4.0 (#2994)
dfd2c4e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: kennytm <kennytm@gmail.com>
@yikeke yikeke added translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 28, 2020
@yikeke yikeke deleted the kennytm/lightning-2020-06 branch July 28, 2020 04:26
@Joyinqin Joyinqin mentioned this pull request Jul 29, 2020
Merged
5 tasks
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Jul 29, 2020
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jul 29, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 3, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer left review comments

@yikeke yikeke yikeke left review comments

@kissmydb kissmydb kissmydb approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees

@Joyinqin Joyinqin

Labels
size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kennytm @ti-srebot @CLAassistant @yikeke @Joyinqin @3pointer @kissmydb