-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
take a time to fix ci 😄 |
This pr just ignores these error logs temporarily. If ideal, the tikv client should be able to handle the incomplete implementation of these interfaces, right? |
LGTM |
No that's not intended to be temporary. The reason is that failing to switch mode won't cause import to fail (just slower), so ignoring the "Unimplemented" error permanently is fine. Yes TiFlash should implement the SwitchMode API (by doing nothing at least), which will make the error go truly away. |
We're always enabling TLS and thus hit tikv/tikv#7209 😭. Either we block on tikv/tikv#7251 or disable the TLS temporarily. /run-all-tests tikv=release-3.1 pd=release-3.1 tidb=release-3.1 |
/run-all-tests |
PTAL @3pointer |
What problem does this PR solve?
Fix #134 and AskTUG-33070.
What is changed and how it works?
./tidb-lightning-ctl --fetch-mode
subcommand to print the mode.Check List
Tests
Side effects
Related changes
--fetch-mode
flag.