Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-statements: add statement reference for ROLES #3198

Merged
merged 3 commits into from Jul 8, 2020
Merged

sql-statements: add statement reference for ROLES #3198

merged 3 commits into from Jul 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 7, 2020

What is changed, added or deleted? (Required)

Fixes #2641

The documentation for the statements associated with ROLES (RBAC) is incomplete and missing examples.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ghost ghost requested a review from tiancaiamao July 7, 2020 22:18
kolbe
kolbe approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@kolbe kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@kolbe, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@yikeke yikeke requested review from zimulala and bb7133 July 8, 2020 01:23
@yikeke yikeke added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jul 8, 2020
@yikeke yikeke requested a review from lilin90 July 8, 2020 01:28
@yikeke
Copy link
Contributor

yikeke commented Jul 8, 2020

PTAL @bb7133 @tiancaiamao @zimulala @lilin90

@bb7133
Copy link
Member

bb7133 commented Jul 8, 2020

I'm not familiar with 'ROLES'-related statements, @imtbkcat PTAL

imtbkcat
imtbkcat approved these changes Jul 8, 2020
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@imtbkcat, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@bb7133 bb7133 added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 8, 2020
@bb7133 bb7133 merged commit 15966df into pingcap:master Jul 8, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 8, 2020
@ti-srebot
cherry pick pingcap#3198 to release-3.0
69b7358 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3205

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 8, 2020
@ti-srebot
cherry pick pingcap#3198 to release-3.1
3a0516c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3206

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 8, 2020
@ti-srebot
cherry pick pingcap#3198 to release-4.0
05357c6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3207

@ghost ghost deleted the stmt-roles branch July 8, 2020 15:31
ghost pushed a commit that referenced this pull request Jul 8, 2020
@ti-srebot
cherry pick #3198 to release-4.0 (#3207)
790acc1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
@ghost ghost mentioned this pull request Jul 8, 2020
Merged
5 tasks
ghost pushed a commit that referenced this pull request Jul 8, 2020
@ti-srebot
sql-statements: add statement reference for ROLES (#3198) (#3206)
ebfb204 
* cherry pick #3198 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

* Add missing sqlgram files

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
ghost pushed a commit that referenced this pull request Jul 8, 2020
@ti-srebot
sql-statements: add statement reference for ROLES (#3198) (#3205)
6ce1055 
* cherry pick #3198 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

* Add missing sqlgram files

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
@ti-srebot ti-srebot mentioned this pull request Jul 10, 2020
Merged
5 tasks
@yikeke yikeke added translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 20, 2020
@yikeke yikeke assigned Joyinqin and unassigned ireneontheway Jul 28, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Aug 11, 2020
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 11, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 11, 2020
Closed
9 tasks
@ran-huang ran-huang mentioned this pull request Aug 19, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Aug 20, 2020
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 21, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Aug 21, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 21, 2020
Merged
9 tasks
This was referenced Sep 1, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@zimulala zimulala Awaiting requested review from zimulala

@bb7133 bb7133 Awaiting requested review from bb7133

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@Joyinqin Joyinqin

Labels
status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Roles syntax in Statement index
8 participants
@ti-srebot @yikeke @bb7133 @Joyinqin @kolbe @imtbkcat @TomShawn @ireneontheway