Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

information-schema: add tidb_hot_regions_history docs and update tidb_hot_regions #6624

Merged
merged 31 commits into from
Jan 20, 2022
Merged

information-schema: add tidb_hot_regions_history docs and update tidb_hot_regions #6624

merged 31 commits into from
Jan 20, 2022

Conversation

IcePigZDB
Copy link
Contributor

@IcePigZDB IcePigZDB commented Oct 17, 2021 •
edited
Loading

Signed-off-by: IcePigZDB icepigzdb@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

  • Add information-schema/information-schema-tidb-hot-regions-history.md to describes the usage of the new tableINFORMATION_SCHEMA.TIDB_HOT_REGIONS_HISTORY.
  • Update the description of INFORMATION_SCHEMA.TIDB_HOT_REGIONS and add link to INFORMATION_SCHEMA.TIDB_HOT_REGIONS_HISTORY.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Oct 17, 2021
@ti-chi-bot
Copy link
Member

Welcome @IcePigZDB!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2021
@IcePigZDB IcePigZDB mentioned this pull request Oct 17, 2021
Merged
15 tasks
@shichun-0415 shichun-0415 added the area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. label Oct 18, 2021
@shichun-0415
Copy link
Contributor

Hi, @IcePigZDB, could you please do the following when you finalize the PR:

  1. Check the links and markdown format because two Jenkins check items have failed.
  2. Fill "What is changed, added or deleted? (Required)".
  3. Specify the version to which you want to merge the PR.
    Thanks.

@IcePigZDB
Copy link
Contributor Author

Hi, @IcePigZDB, could you please do the following when you finalize the PR:

  1. Check the links and markdown format because two Jenkins check items have failed.
  2. Fill "What is changed, added or deleted? (Required)".
  3. Specify the version to which you want to merge the PR.
    Thanks.

roger that, I will mention @you and change thir PR Ready for review after fix them.

@TomShawn
Copy link
Contributor

@IcePigZDB Please help confirm whether this feature is v5.3 related. If yes, please add the v5.3 label. Thanks!

This was referenced Oct 18, 2021
Merged
Merged
@IcePigZDB
Copy link
Contributor Author

Hi, @IcePigZDB, could you please do the following when you finalize the PR:

  1. Check the links and markdown format because two Jenkins check items have failed.
  2. Fill "What is changed, added or deleted? (Required)".
  3. Specify the version to which you want to merge the PR.
    Thanks.

roger that, I will mention @you and change thir PR Ready for review after fix them.

  1. I forget to mention the related config PR(doc:add config for hot region history and add command for pd ctl  #6627), Dead anchor: /pd-configuration-file.md#hot-regions-write-interval should be fixed after the merge of it.
  2. Fill "What is changed, added or deleted? (Required)".
  3. This feature is v5.3 related, I have add the v5.3 label in description.

@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. v5.3 This PR/issue applies to TiDB v5.3. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. and removed missing-translation-status This PR does not have translation status info. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. labels Oct 19, 2021
@IcePigZDB
Copy link
Contributor Author

@TomShawn change to v5.4, please help to change the label.

@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed v5.3 This PR/issue applies to TiDB v5.3. translation/doing This PR's assignee is translating this PR. labels Nov 3, 2021
@TomShawn TomShawn added v5.4 This PR/issue applies to TiDB v5.4. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Dec 20, 2021
@IcePigZDB IcePigZDB marked this pull request as ready for review December 21, 2021 01:50
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2022
@IcePigZDB IcePigZDB mentioned this pull request Jan 15, 2022
Closed
TomShawn
TomShawn approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

information-schema/information-schema-tidb-hot-regions-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-hot-regions-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-hot-regions-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-hot-regions-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-hot-regions-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-hot-regions-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-hot-regions-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-hot-regions-history.md Outdated Show resolved Hide resolved
information-schema/information-schema-tidb-hot-regions.md Outdated Show resolved Hide resolved
information-schema/information-schema.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 20, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 07ab85a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@TomShawn
Copy link
Contributor

/verify

3 similar comments
@TomShawn
Copy link
Contributor

/verify

@TomShawn
Copy link
Contributor

/verify

@TomShawn
Copy link
Contributor

/verify

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 66b19c2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@ti-chi-bot ti-chi-bot merged commit 0da6e2d into pingcap:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@hfxsd hfxsd

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@IcePigZDB @ti-chi-bot @CLAassistant @shichun-0415 @TomShawn @hfxsd