Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record history hotspot information in TIDB_HOT_REGIONS #25281

Closed
4 tasks done
nolouch opened this issue Jun 9, 2021 · 4 comments
Closed
4 tasks done

Record history hotspot information in TIDB_HOT_REGIONS #25281

nolouch opened this issue Jun 9, 2021 · 4 comments

Comments

@nolouch
Copy link
Member

nolouch commented Jun 9, 2021

Description

TiDB has a memory table TIDB_HOT_REGIONS that provides information about hotspot Regions. But it only shows the current hotspot information. This leads to the fact that when DBAs want to query historical hotspot details, they have no way to find the corresponding hotspot information.

Document Collection

Talent Challenge Program information

Milestones and action items

Milestone 1: design and implement, Expected finish date: 2m

Milestone 2: test and document, release it. Expected finish date: 1m

  • Test & Document

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • Go

Learning Materials

@tisonkun
Copy link
Contributor

@IcePigZDB @nolouch could you please create subtasks issue instead of organize the development in PRs?

@nolouch
Copy link
Member Author

nolouch commented Sep 2, 2021

/assign @IcePigZDB @qidi1

@nolouch
Copy link
Member Author

nolouch commented Sep 2, 2021

/assign @qidi1

@ti-chi-bot
Copy link
Member

@nolouch: GitHub didn't allow me to assign the following users: qidi1.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @qidi1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qidi1 added a commit to IcePigZDB/pd that referenced this issue Oct 25, 2021
nolouch added a commit to tikv/pd that referenced this issue Oct 27, 2021
* core:remove compaction for hot region history ref #pingcap/tidb/pull/25281

Signed-off-by: qidi1 <1083369179@qq.com>

* ref #4020

Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: nolouch <nolouch@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
hzh0425 pushed a commit to hzh0425/pd that referenced this issue Nov 16, 2021
* core:remove compaction for hot region history ref #pingcap/tidb/pull/25281

Signed-off-by: qidi1 <1083369179@qq.com>

* ref tikv#4020

Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: nolouch <nolouch@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: hzh0425 <642256541@qq.com>
qidi1 added a commit to IcePigZDB/pd that referenced this issue Nov 29, 2021
qidi1 added a commit to IcePigZDB/pd that referenced this issue Nov 29, 2021
nolouch pushed a commit to tikv/pd that referenced this issue Dec 21, 2021
* command:add hot-history-regions command(ref #pingcap/tidb/issues/25281)

Signed-off-by: qidi1 <1083369179@qq.com>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Dec 28, 2021
…4103)

* command:add hot-history-regions command(ref #pingcap/tidb/issues/25281)

Signed-off-by: qidi1 <1083369179@qq.com>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
qidi1 added a commit to IcePigZDB/pd that referenced this issue Jan 4, 2022
ref #pingcap/tidb/issues/25281

Signed-off-by: qidi1 <1083369179@qq.com>
qidi1 added a commit to IcePigZDB/pd that referenced this issue Jan 4, 2022
ref #pingcap/tidb/issues/25281

Signed-off-by: qidi1 <1083369179@qq.com>
qidi1 added a commit to IcePigZDB/pd that referenced this issue Jan 4, 2022
ref #pingcap/tidb/issues/25281

Signed-off-by: qidi1 <1083369179@qq.com>
qidi1 added a commit to IcePigZDB/pd that referenced this issue Jan 4, 2022
ref #pingcap/tidb/issues/25281

Signed-off-by: qidi1 <1083369179@qq.com>
qidi1 added a commit to IcePigZDB/pd that referenced this issue Jan 5, 2022
ref #pingcap/tidb/issues/25281

Signed-off-by: qidi1 <1083369179@qq.com>
ti-chi-bot added a commit to tikv/pd that referenced this issue Jan 11, 2022
… reboot (#4539)

* fix bug of hot_region_history

Signed-off-by: qidi1 <1083369179@qq.com>

* config:make config can be change
ref #pingcap/tidb/issues/25281

Signed-off-by: qidi1 <1083369179@qq.com>

* server:address comment and add unit test

Signed-off-by: qidi1 <1083369179@qq.com>

Co-authored-by: IcePigZDB <icepigzdb@gmail.com>

* server:data race

Signed-off-by: qidi1 <1083369179@qq.com>

* core:add integration test for config change

Signed-off-by: qidi1 <1083369179@qq.com>

* core:remove config change unit test

Signed-off-by: qidi1 <1083369179@qq.com>

* core:add getCurReservedDays and getCurInterval

Signed-off-by: qidi1 <1083369179@qq.com>

Co-authored-by: IcePigZDB <icepigzdb@gmail.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit to ti-chi-bot/pd that referenced this issue Jan 11, 2022
… reboot (tikv#4539)

* fix bug of hot_region_history

Signed-off-by: qidi1 <1083369179@qq.com>

* config:make config can be change
ref #pingcap/tidb/issues/25281

Signed-off-by: qidi1 <1083369179@qq.com>

* server:address comment and add unit test

Signed-off-by: qidi1 <1083369179@qq.com>

Co-authored-by: IcePigZDB <icepigzdb@gmail.com>

* server:data race

Signed-off-by: qidi1 <1083369179@qq.com>

* core:add integration test for config change

Signed-off-by: qidi1 <1083369179@qq.com>

* core:remove config change unit test

Signed-off-by: qidi1 <1083369179@qq.com>

* core:add getCurReservedDays and getCurInterval

Signed-off-by: qidi1 <1083369179@qq.com>

Co-authored-by: IcePigZDB <icepigzdb@gmail.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@nolouch nolouch closed this as completed Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants