op-guide, media: update monitoring docs #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalvin
reviewed
Mar 22, 2019
|
@dcalvin Thanks! Updated. PTAL again~ @liubo0127 PTAL |
|
morgo
reviewed
Mar 25, 2019
|
There was one pre-existing sentence I improved for clarity. Otherwise LGTM |
Co-Authored-By: lilin90 <lilin@pingcap.com>
|
@liubo0127 Then I'll remove the Pushgateway section and update the JSON file link. |
|
@liubo0127 @morgo @dcalvin Thanks! Updated. PTAL again~ |
dcalvin
reviewed
Mar 27, 2019
dcalvin
reviewed
Mar 27, 2019
Co-Authored-By: lilin90 <lilin@pingcap.com>
lilin90
added a commit
to lilin90/docs-cn
that referenced
this pull request
Apr 3, 2019
lilin90
added a commit
to pingcap/docs-cn
that referenced
this pull request
Jun 27, 2019
* op-guide: udpate TiDB monitoring docs Via: pingcap/docs#965 * op-guide: update punctuation * op-guide: add a "&" character * media: update the image size * v2.1-legacy: update content for v2.1-legacy * *: update content in dev, v3.0, v2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two points:
I checked with the DBA and got that in TiDB v3.0-beta and v2.1, Pushgateway is not used anymore (not supported) in PD and TiDB, while it's optional in TiKV.
In this PR, I add a statement and keep the Pushgateway section. I didn't use Pushgateway in my testing. Removing it might make the document/process much clearer and simpler. Do we need to remove this Pushgateway section in v3.0 docs?
I learned that the JSON file link (in the current document) is not up-to-date. Could we use the files in the tidb-ansible repo? @liubo0127
Related PR: #944
@liubo0127 @morgo @c4pt0r @dcalvin PTAL