This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
*: use show full tables in ListAllDatabasesTables (#325)
#333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 18628e5
|
nongfushanquan
added
cherry-pick-approved
and removed
do-not-merge/cherry-pick-not-approved
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #325
What problem does this PR solve?
close #322
What is changed and how it works?
when meet a specific buggy version of mysql [8.0.3 8.0.23), use SQL
show full tablesto get all table names from upstream database.As the average data size per row of data is not taken from the
Show full tableresults, dumpling will set this value to200000.This has the potential to cause the user to export too many or too few files, but I find this more acceptable than getting stuck in the dump stage.
Check List
Tests
Side effects
Related changes
Release note
show table statusin some mysql version