-
Notifications
You must be signed in to change notification settings - Fork 85
*: use show full tables
in ListAllDatabasesTables
#325
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ae67d50
to
64e0eae
Compare
show full tabes
in ListAllDatabasesTables
show full tabes
in ListAllDatabasesTablesshow full tables
in ListAllDatabasesTables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a mysql 8 test for this PR?
show full tables
in ListAllDatabasesTablesshow full tables
in ListAllDatabasesTables
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f159d85
|
dumpling has updated the integration tests requirements in pingcap/dumpling#325
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #331. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #332. |
In response to a cherrypick label: new pull request created: #333. |
In response to a cherrypick label: new pull request created: #342. |
What problem does this PR solve?
close #322
What is changed and how it works?
when meet a specific buggy version of mysql [8.0.3 8.0.23), use SQL
show full tables
to get all table names from upstream database.As the average data size per row of data is not taken from the
Show full table
results, dumpling will set this value to200000
.This has the potential to cause the user to export too many or too few files, but I find this more acceptable than getting stuck in the dump stage.
Check List
Tests
Side effects
Related changes
Release note
show table status
in some mysql version