Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

*: use show full tables in ListAllDatabasesTables #325

Merged
merged 15 commits into from
Aug 6, 2021

Conversation

Ehco1996
Copy link
Contributor

@Ehco1996 Ehco1996 commented Aug 3, 2021

What problem does this PR solve?

close #322

What is changed and how it works?

when meet a specific buggy version of mysql [8.0.3 8.0.23), use SQL show full tables to get all table names from upstream database.

As the average data size per row of data is not taken from the Show full table results, dumpling will set this value to 200000.
This has the potential to cause the user to export too many or too few files, but I find this more acceptable than getting stuck in the dump stage.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • fix pending on show table status in some mysql version

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Ehco1996 Ehco1996 changed the title consistency: auto change consistency to lock *: use show full tabes in ListAllDatabasesTables Aug 3, 2021
@Ehco1996 Ehco1996 marked this pull request as ready for review August 3, 2021 06:33
@Ehco1996 Ehco1996 changed the title *: use show full tabes in ListAllDatabasesTables *: use show full tables in ListAllDatabasesTables Aug 3, 2021
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a mysql 8 test for this PR?

v4/export/dump.go Outdated Show resolved Hide resolved
v4/export/sql.go Outdated Show resolved Hide resolved
v4/export/config.go Outdated Show resolved Hide resolved
v4/export/config.go Outdated Show resolved Hide resolved
v4/export/config_test.go Outdated Show resolved Hide resolved
v4/export/dump.go Outdated Show resolved Hide resolved
@Ehco1996 Ehco1996 changed the title *: use show full tables in ListAllDatabasesTables WIP*: use show full tables in ListAllDatabasesTables Aug 4, 2021
@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Aug 4, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f159d85

ti-chi-bot pushed a commit to ti-community-infra/configs that referenced this pull request Aug 6, 2021
dumpling has updated the integration tests requirements in pingcap/dumpling#325
@ti-chi-bot ti-chi-bot merged commit 4e012e5 into pingcap:master Aug 6, 2021
ti-chi-bot pushed a commit to ti-chi-bot/dumpling that referenced this pull request Aug 6, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #331.

ti-chi-bot pushed a commit to ti-chi-bot/dumpling that referenced this pull request Aug 6, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #332.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #333.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #342.

tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump pending on SHOW TABLE STATUS FROM all_generate_column
4 participants