Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topsql: add backend of group by table or db #262

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Sep 18, 2024

What problem does this PR solve?

Issue Number: close #266 ref pingcap/tidb#55540

What is changed and how it works?

the relative backend #262
demo2

@nolouch
Copy link
Member Author

nolouch commented Sep 18, 2024

/hold

@nolouch
Copy link
Member Author

nolouch commented Sep 20, 2024

/uncc ngaut qiuyesuifeng

@nolouch
Copy link
Member Author

nolouch commented Sep 20, 2024

/cc @crazycs520

@ti-chi-bot ti-chi-bot bot requested a review from crazycs520 September 20, 2024 05:49
@nolouch nolouch force-pushed the add-api-for-more-dim branch from 413df8a to 85c9f90 Compare September 20, 2024 05:54
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch force-pushed the add-api-for-more-dim branch from 4611604 to f3db2c2 Compare September 20, 2024 06:11
@nolouch
Copy link
Member Author

nolouch commented Sep 20, 2024

/unhold

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 03:07:06.517198329 +0000 UTC m=+1448896.257622249: ☑️ agreed by crazycs520.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit 78151ff into pingcap:main Sep 23, 2024
2 checks passed
@nolouch nolouch deleted the add-api-for-more-dim branch September 23, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add backend of group by table or db of topsql
2 participants