Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topsql: add ui for aggregating by table or db #1732

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Sep 19, 2024

@ti-chi-bot ti-chi-bot bot requested a review from Renkai September 19, 2024 16:23
@ti-chi-bot ti-chi-bot bot added the size/XXL label Sep 19, 2024
@nolouch nolouch force-pushed the enhance-topsql branch 3 times, most recently from ea44269 to 9c4f443 Compare September 19, 2024 17:37
Signed-off-by: nolouch <nolouch@gmail.com>
@baurine
Copy link
Collaborator

baurine commented Sep 23, 2024

in reviewing, will finish reviewing in 9.24.

Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works fine with old TiDB versions.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 03:52:19.031474443 +0000 UTC m=+1538008.771898380: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit 618b5cd into pingcap:master Sep 24, 2024
7 of 8 checks passed
@nolouch nolouch deleted the enhance-topsql branch September 24, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants