Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add a mysql error message (#534) #627

Merged
merged 2 commits into from
Nov 11, 2019
Merged

parser: add a mysql error message (#534) #627

merged 2 commits into from
Nov 11, 2019

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 8, 2019

Cherry-pick #534.

@codecov
Copy link

codecov bot commented Nov 8, 2019 •
edited
Loading

Codecov Report

Merging #627 into release-3.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-3.1     #627   +/-   ##
============================================
  Coverage        51.27%   51.27%           
============================================
  Files               31       31           
  Lines             6888     6888           
============================================
  Hits              3532     3532           
  Misses            3006     3006           
  Partials           350      350
Impacted Files Coverage Δ
ast/functions.go 70.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f0a51...a3fca1b. Read the comment docs.

kennytm
kennytm reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Nov 8, 2019
AilinKid
AilinKid approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Nov 11, 2019
@tangenta tangenta merged commit 9736f3e into pingcap:release-3.1 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/cherry-pick-for-release-3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tangenta @kennytm @AilinKid