Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support require clauses in grant stmt (#666) #698

Merged
merged 1 commit into from
Dec 24, 2019
Merged

support require clauses in grant stmt (#666) #698

merged 1 commit into from
Dec 24, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Dec 24, 2019 •
edited
Loading

cherry-pick #666 to 3.0

This change is Reviewable

tangenta
tangenta reviewed Dec 24, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 LGT1 label Dec 24, 2019
@lysu lysu mentioned this pull request Dec 24, 2019
Merged
imtbkcat
imtbkcat approved these changes Dec 24, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu merged commit 93f4d5e into pingcap:release-3.0 Dec 24, 2019
@lysu lysu deleted the cp30-require branch December 24, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@imtbkcat imtbkcat imtbkcat approved these changes

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
status/LGT1 LGT1 type/cherry-pick-for-release-3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lysu @imtbkcat @tangenta