Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support certificate based authentication (#13955) #14202

Merged
merged 5 commits into from
Dec 26, 2019
Merged

*: support certificate based authentication (#13955) #14202

merged 5 commits into from
Dec 26, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Dec 24, 2019

cherry-pick #13955 to 3.0

mainly conflict:

  • logutil.Bg -> logutil.Logger(context.Background())
  • ExecRestrictedSQL need pass ctx in 3.0
  • MySQLPrivilege's map speed up pr doesn't cherry-pick
  • TestFastAnalyze table name +2

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Dec 24, 2019

need merge pingcap/parser#698 before this pr

@lysu
Copy link
Contributor Author

lysu commented Dec 24, 2019

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2019
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 26, 2019
@jackysp
Copy link
Member

jackysp commented Dec 26, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 26, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 26, 2019

@lysu merge failed.

@lysu
Copy link
Contributor Author

lysu commented Dec 26, 2019

@jackysp need remerge

@jackysp
Copy link
Member

jackysp commented Dec 26, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit eb355be into pingcap:release-3.0 Dec 26, 2019
@lysu lysu deleted the cp30-cert-auth branch January 3, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants