Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: picks some hot-region improvements to release 3.1 #2342

Merged
merged 9 commits into from
Apr 10, 2020

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 10, 2020

What problem does this PR solve?

picks some hot region improvements to release-3.1

What is changed and how it works?

cherry jpick

Release note

Check List

Tests

  • Unit test

Luffbee and others added 9 commits April 10, 2020 19:06
* schedulers: add some metrics for hotreigon

Signed-off-by: nolouch <nolouch@gmail.com>
* scheduelrs: add load expectations for hot scheudler

Signed-off-by: nolouch <nolouch@gmail.com>
…lanced (tikv#2298)

* schedulers/hot: let leader can be schedule even if the peer is not balanced

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added this to the v3.1.0-ga milestone Apr 10, 2020
@nolouch nolouch added the component/scheduler Scheduler logic. label Apr 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #2342 into release-3.1 will increase coverage by 0.03%.
The diff coverage is 84.53%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.1    #2342      +/-   ##
===============================================
+ Coverage        75.12%   75.15%   +0.03%     
===============================================
  Files              196      197       +1     
  Lines            20331    20772     +441     
===============================================
+ Hits             15274    15612     +338     
- Misses            3889     3976      +87     
- Partials          1168     1184      +16     
Impacted Files Coverage Δ
server/cluster/cluster.go 81.05% <ø> (+0.22%) ⬆️
server/statistics/hot_peer.go 100.00% <ø> (ø)
tools/pd-ctl/pdctl/command/scheduler.go 68.07% <51.85%> (-1.18%) ⬇️
server/cluster/coordinator.go 74.45% <70.00%> (-3.52%) ⬇️
server/schedulers/hot_region.go 82.34% <81.36%> (-3.13%) ⬇️
server/schedulers/hot_region_config.go 84.21% <84.21%> (ø)
server/statistics/avg_over_time.go 86.84% <95.45%> (-13.16%) ⬇️
pkg/mock/mockcluster/mockcluster.go 91.57% <100.00%> (+1.31%) ⬆️
server/schedulers/metrics.go 100.00% <100.00%> (ø)
server/schedulers/shuffle_hot_region.go 73.87% <100.00%> (+0.97%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26bf96...40390b2. Read the comment docs.

@nolouch
Copy link
Contributor Author

nolouch commented Apr 10, 2020

/run-all-tests

@HunDunDM
Copy link
Member

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 10, 2020

/run-all-tests

@sre-bot sre-bot merged commit 8b7475c into tikv:release-3.1 Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants