Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer: support load table infos to save memory and add gc safepoint update #1233

Merged
merged 7 commits into from
May 29, 2023
Merged

drainer: support load table infos to save memory and add gc safepoint update #1233

merged 7 commits into from
May 29, 2023

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #1137

What is changed and how it works?

  1. support load table infos from tidb
  2. add gc safepoint ttl update to avoid table info is gced

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

  • No release note

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/L label May 22, 2023
@lichunzhu lichunzhu changed the base branch from master to release-6.5-20230522-v6.5.2 May 22, 2023 07:33
@lichunzhu lichunzhu changed the base branch from release-6.5-20230522-v6.5.2 to release-6.5-20230522-v6.5.2-1 May 22, 2023 07:35
@lichunzhu
Copy link
Contributor Author

/run-integration-tests

@lichunzhu lichunzhu changed the base branch from release-6.5-20230522-v6.5.2-1 to master May 23, 2023 04:01
GMHDBJD
GMHDBJD approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niubell niubell requested a review from lance6716 May 29, 2023 04:36
lance6716
lance6716 reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

drainer/safepoint.go

func updateServiceSafePoint(ctx context.Context, pdClient pd.Client, cpt checkpoint.CheckPoint, ttl int64) {
updateInterval := time.Duration(ttl/2) * time.Second
tick := time.NewTicker(updateInterval)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tick.Stop

Copy link
Contributor Author

@lichunzhu lichunzhu May 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 19e727c

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 19e727c

@ti-chi-bot ti-chi-bot bot merged commit 9ab2794 into pingcap:master May 29, 2023
@lichunzhu lichunzhu deleted the fixLoadTableInfo2 branch May 29, 2023 07:47
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request May 29, 2023
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-6.5: #1234.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 29, 2023
@ti-chi-bot
drainer: support load table infos to save memory and add gc safepoint…
f44542a 
… update (#1233) (#1234)

ref #1137
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-6.5-20230522-v6.5.2-1

@ti-chi-bot ti-chi-bot mentioned this pull request May 30, 2023
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-6.5-20230522-v6.5.2-1: #1235.

In response to this:

/cherry-pick release-6.5-20230522-v6.5.2-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
@ti-chi-bot
drainer: support load table infos to save memory and add gc safepoint…
c5ac394 
… update (#1233) (#1235)

ref #1137
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2023
Merged
@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-7.1: #1259.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 6, 2023
@ti-chi-bot
drainer: support load table infos to save memory and add gc safepoint…
c736e3f 
… update (#1233) (#1259)

ref #1137
lichunzhu pushed a commit to lichunzhu/tidb-binlog that referenced this pull request Oct 13, 2023
@ti-chi-bot @lichunzhu
drainer: support load table infos to save memory and add gc safepoint…
8614b2f 
… update (pingcap#1233) (pingcap#1234)

ref pingcap#1137
ti-chi-bot bot pushed a commit that referenced this pull request Oct 13, 2023
@lichunzhu
drainer: support load table infos to save memory and add gc safepoint…
984d839 
… update (#1233) (#1268)

ref #1137
@lichunzhu
Copy link
Contributor Author

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@lichunzhu: new pull request created to branch release-6.1: #1271.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 16, 2023
@ti-chi-bot
drainer: support load table infos to save memory and add gc safepoint…
9dcfd1f 
… update (#1233) (#1271)

ref #1137
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 16, 2023
@ti-chi-bot
drainer: support load table infos to save memory and add gc safepoint…
904128a 
… update (#1233) (#1271) (#1272)

ref #1137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
size/L status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lichunzhu @ti-chi-bot @lance6716 @GMHDBJD