Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer: support load table infos to save memory and add gc safepoint update (#1233) #1271

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 16, 2023

This is an automated cherry-pick of #1233

What problem does this PR solve?

Issue Number: ref #1137

What is changed and how it works?

  1. support load table infos from tidb
  2. add gc safepoint ttl update to avoid table info is gced

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

None

@lichunzhu
Copy link
Contributor

/retest

@lichunzhu
Copy link
Contributor

/run-unit-test

Copy link

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 16, 2023

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

/lgtm

Copy link

ti-chi-bot bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance6716,lichunzhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-16 06:55:44.1037406 +0000 UTC m=+4318541.690850741: ☑️ agreed by lichunzhu.
  • 2023-11-16 07:16:29.413522769 +0000 UTC m=+4319787.000632910: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 9dcfd1f into pingcap:release-6.1 Nov 16, 2023
6 checks passed
@lichunzhu
Copy link
Contributor

/cherry-pick release-6.1-20231116-v6.1.7

@ti-chi-bot
Copy link
Member Author

@lichunzhu: new pull request created to branch release-6.1-20231116-v6.1.7: #1272.

In response to this:

/cherry-pick release-6.1-20231116-v6.1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants