drainer/*: get latest timestamp from pd when initial-commit-ts is -1 #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsyh
reviewed
Oct 30, 2019
Co-Authored-By: Eric Shen <ericshenyuhao@outlook.com>
|
LGTM |
|
/run-all-tests |
|
@july2993 merge failed. |
|
/merge |
|
/run-all-tests |
|
@july2993 merge failed. |
|
please fix CI @july2993 |
don't rely on privier drainer instance
|
/run-all-tests |
|
/run-all-tests |
|
@suzaku @GregoryIan PTAL |
|
@suzaku pls approve |
suzaku
approved these changes
Nov 4, 2019
|
cherry pick to release-3.0 in PR #788 |
|
cherry pick to release-3.1 in PR #789 |
sre-bot
added a commit
that referenced
this pull request
Nov 5, 2019
sre-bot
added a commit
that referenced
this pull request
Nov 5, 2019
july2993
added a commit
to july2993/docs-cn
that referenced
this pull request
Nov 7, 2019
july2993
added a commit
to july2993/docs-cn
that referenced
this pull request
Nov 7, 2019
july2993
added a commit
to pingcap/docs-cn
that referenced
this pull request
Dec 13, 2019
* Update docs about checkpoint & initial-commit-ts relate prs: pingcap/tidb-binlog#787 pingcap/tidb-binlog#786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
easy deploy for starting at the latest timestamp
What is changed and how it works?
drainer/*: get the latest timestamp from PD when initial-commit-ts is -1
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansiblerepository