Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unique key info in slave proto #858

Merged
merged 4 commits into from
Dec 28, 2019
Merged

Add unique key info in slave proto #858

merged 4 commits into from
Dec 28, 2019

Conversation

july2993
Copy link
Contributor

What problem does this PR solve?

Add unique key info in slave proto

What is changed and how it works?

Add unique key info in slave proto
need pingcap/tidb-tools#310 merged first

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
create aa(id int);
create table a3(id varchar(255) primary key, c2 int, c3 int, unique key idx1(c3,c2));
create table a3(id int primary key, c2 int, c3 int, unique key idx1(c3,c2));

//and insert data and check the proto works as exptected

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

suzaku
suzaku reviewed Dec 27, 2019
View reviewed changes
Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zier-one
zier-one previously approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link

sre-bot commented Dec 27, 2019

/run-all-tests

@sre-bot
Copy link

sre-bot commented Dec 27, 2019

@july2993 merge failed.

@july2993
Fix test
45912ad 
The offset in IndexInfo is the index of TableInfo.Columns
@july2993
Merge remote-tracking branch 'july2993/add_uk' into add_uk
d89ffe6
@july2993
Copy link
Contributor Author

/run-all-tests

@july2993 july2993 mentioned this pull request Dec 27, 2019
Open
@july2993 july2993 merged commit 254a465 into pingcap:master Dec 28, 2019
@july2993 july2993 deleted the add_uk branch December 28, 2019 03:28
@sre-bot
Copy link

sre-bot commented Dec 28, 2019

cherry pick to release-3.0 failed

@july2993 july2993 mentioned this pull request Dec 28, 2019
Merged
july2993 added a commit to july2993/tidb-binlog that referenced this pull request Dec 30, 2019
@july2993
Add unique key info in slave proto (pingcap#858)
3e065a0
@july2993 july2993 mentioned this pull request Dec 30, 2019
Merged
sre-bot pushed a commit that referenced this pull request Jan 5, 2020
@july2993 @sre-bot
Add unique key info in slave proto (#858) (#862)
1874f90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzaku suzaku suzaku left review comments

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@july2993 @sre-bot @suzaku @zier-one