Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique key info in slave proto (#858) #862

Merged
merged 2 commits into from
Jan 5, 2020

Conversation

july2993
Copy link
Contributor

What problem does this PR solve?

cherry-pick #858

What is changed and how it works?

cherry-pick #858

Check List

Tests

Related changes

  • Need to update the documentation

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link

sre-bot commented Jan 2, 2020

/run-all-tests

@sre-bot
Copy link

sre-bot commented Jan 2, 2020

@july2993 merge failed.

@july2993
Copy link
Contributor Author

july2993 commented Jan 5, 2020

/merge

@sre-bot
Copy link

sre-bot commented Jan 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit 1874f90 into pingcap:release-3.0 Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants