chore: support multiple profiling types #1095

YiniXu9506 · 2021-12-13T05:34:37Z

What did

Add multi-select for profiling types: CPU, Heap, Goroutine, Mutex
Update taskGroupState, the logic is:
- there has error task in taskGroup, the groupState is Error
- there has no error task, the groupState is Finished even if there exists skippedTasks.
Groupby tasks in profiling detail page.
Skip Heap, Goroutine and Mutex profiling for TiKV/TiFlash.

Result can be previewed:

ti-chi-bot · 2021-12-13T05:34:38Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

breezewish · 2021-12-14T01:48:51Z

Cool! How about adding a (?) icon and some tooltip explanation to the skipped state to tell user the reason that it skipped?

pkg/apiserver/profiling/model.go

…u9506/tidb-dashboard into supportMultiProfilingTypes

breezewish

the rest LGTM

pkg/apiserver/profiling/model.go

pkg/apiserver/profiling/profile.go

pkg/apiserver/profiling/service.go

breezewish · 2021-12-16T05:13:35Z

@baurine @shhdgit PTAL

…u9506/tidb-dashboard into supportMultiProfilingTypes

ui/lib/apps/InstanceProfiling/pages/Detail.tsx

CLAassistant · 2021-12-19T17:01:17Z

All committers have signed the CLA.

ui/lib/apps/InstanceProfiling/pages/Detail.tsx

shhdgit

Rest LGTM.

pkg/apiserver/profiling/service.go

pkg/apiserver/profiling/model.go

baurine

lgtm

breezewish

The rest LGTM

ui/lib/apps/InstanceProfiling/pages/Detail.tsx

baurine

the rest lgtm

ui/lib/apps/InstanceProfiling/pages/Detail.tsx

breezewish · 2021-12-22T06:51:19Z

/merge

ti-chi-bot · 2021-12-22T06:51:21Z

This pull request has been accepted and is ready to merge.

Commit hash: 34538d8

* Revert "Release v2021.12.06.1 (#1084)" This reverts commit bcc43a0. * Compitable with different TiDB versions for conprof and non-root-login features (#1047) * make conprof independent * check feature enable * add check feature enable middleware * hide menu if feature is not enabled * refactor non root login switch by new design * i18n * yarn fmt * renaming * adjust fe code * refine * remove unused log * build(deps): bump ws from 5.2.2 to 5.2.3 in /ui (#1055) * CICD: Update the release pipeline for recent PD format policies (#1054) * fix i18n wording (#1056) * Refactor: Change util module to util package (#1052) * Refactor: Fix godot incorrectly add dot suffix to annotations (#1059) * lint: Add goheader for copyright lints (#1062) * Refactor: Migrate to use the `rest` package in util/ (#1060) * fix(*): globally delete/update data by GORM (#1065) * ui: bump dependencies (#1066) * refactor: Switch to use ziputil, netutil, reflectutil and fileswap (#1067) * Fix request header being pinned after pd profiling (#1069) * Integrate speedscope (#1064) * fix potential panic when GetPDInstances (#1075) Signed-off-by: crazycs <chen.two.cs@gmail.com> * Refactor: a new httpclient (#1073) * Refactor: Switch to use util/distro in all places (#1078) * chore: support import relative file URL (#1082) * Refactor: Move tools into a standalone module (#1079) * Fix script to embed the ui (#1088) * Fix script to embed the ui * Hack write_strings * Refactor feature flag to support more modules (#1057) * Drop sysutil dependency (#1093) * chore: add graph generation (#1085) * Refactor: Add TopologyProvider (#1098) * esbuild: i18n + dep (#1101) * script: Add a script to generate version matrix (#1104) * distro: support dynamic config (#1094) * chore: support multiple profiling types (#1095) * fix(distro): check distro_strings.json fmt by prettier (#1106) * script: fix generate assets (#1107) * Add integration test (#1083) * debug_api: Switch to use the new util (#1103) * refactor(ui): auto refresh button (#1105) * refactor(ui): auto refresh button * chore: update translation * fix: remain seconds * refine: refresh button * fix: onRefresh * fix: auto refresh * fix: continue tick * chore: add some comments * tweak: remaining refresh seconds * chore: clean code Co-authored-by: Wenxuan <breezewish@pingcap.com> * ui: refine conprof (#1102) * update wording * not check prom any more * replace time range component * i18n * support view profile by diffrent ways * extract ActionsButton * change download data format * refine * comments * Revert "comments" This reverts commit 3b03fdb. * fix view cpu profile fail * update state * hide action button if disable * address feedback * update release-version * sync with master Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wenxuan <breezewish@pingcap.com> Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: Yini Xu <34967660+YiniXu9506@users.noreply.github.com> Co-authored-by: crazycs <crazycs520@gmail.com>

chore: support multiple profiling types

40010b9

YiniXu9506 requested a review from breezewish December 13, 2021 05:34

ti-chi-bot added the needs-rebase label Dec 14, 2021

merge from master and resolve conflicts

564e24d

ti-chi-bot removed the needs-rebase label Dec 14, 2021

breezewish reviewed Dec 14, 2021

View reviewed changes

YiniXu9506 and others added 5 commits December 15, 2021 14:09

chore: reovle comments"

08982e3

Merge branch 'supportMultiProfilingTypes' of https://github.com/YiniX…

b5d1b25

…u9506/tidb-dashboard into supportMultiProfilingTypes

fix component infinit loop

8a25baa

resolve conflicts

2a268c3

Merge branch 'master' into supportMultiProfilingTypes

2b42acf

breezewish reviewed Dec 16, 2021

View reviewed changes

YiniXu9506 and others added 4 commits December 17, 2021 00:46

chore: check requested profiling type validation

5447346

Merge branch 'supportMultiProfilingTypes' of https://github.com/YiniX…

84c85a3

…u9506/tidb-dashboard into supportMultiProfilingTypes

fix format

a4b54e5

Merge branch 'master' into supportMultiProfilingTypes

c8c12f1

baurine reviewed Dec 17, 2021

View reviewed changes

ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved

baurine reviewed Dec 17, 2021

View reviewed changes

ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved

baurine reviewed Dec 17, 2021

View reviewed changes

ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved

baurine reviewed Dec 17, 2021

View reviewed changes

ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved

chore: resolve comments

7c0ba64

YiniXu9506 force-pushed the supportMultiProfilingTypes branch from c5e75dd to 7c0ba64 Compare December 20, 2021 02:27

YiniXu9506 requested review from breezewish and baurine December 20, 2021 06:05

baurine reviewed Dec 20, 2021

View reviewed changes

ui/lib/apps/InstanceProfiling/pages/Detail.tsx Show resolved Hide resolved

baurine reviewed Dec 20, 2021

View reviewed changes

ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved

update profiling detail table

8d9f103

YiniXu9506 requested a review from baurine December 20, 2021 08:58

shhdgit reviewed Dec 20, 2021

View reviewed changes

pkg/apiserver/profiling/service.go Outdated Show resolved Hide resolved

pkg/apiserver/profiling/model.go Outdated Show resolved Hide resolved

use map structure to check type validation

9551288

YiniXu9506 requested a review from shhdgit December 20, 2021 09:59

baurine reviewed Dec 20, 2021

View reviewed changes

breezewish approved these changes Dec 20, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 label Dec 20, 2021

This was referenced Dec 20, 2021

debug_api: Switch to use the new util #1103

Merged

Refine conprof #1102

Merged

breezewish assigned baurine Dec 21, 2021

baurine approved these changes Dec 21, 2021

View reviewed changes

YiniXu9506 and others added 2 commits December 21, 2021 19:37

chore: refine Action buttons

8ecd2ea

Merge branch 'master' into supportMultiProfilingTypes

54c5c80

breezewish reviewed Dec 21, 2021

View reviewed changes

ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved

update interface naming

f1eeb70

YiniXu9506 requested a review from breezewish December 22, 2021 03:34

Merge branch 'master' into supportMultiProfilingTypes

34538d8

ti-chi-bot added the status/can-merge label Dec 22, 2021

ti-chi-bot merged commit c1346d2 into pingcap:master Dec 22, 2021

YiniXu9506 deleted the supportMultiProfilingTypes branch December 22, 2021 08:28

breezewish mentioned this pull request Dec 29, 2021

Support other types of profile and flame graph #717

Closed

baurine pushed a commit to baurine/tidb-dashboard that referenced this pull request Dec 30, 2021

chore: support multiple profiling types (pingcap#1095)

6bdcdf2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: support multiple profiling types #1095

chore: support multiple profiling types #1095

YiniXu9506 commented Dec 13, 2021

ti-chi-bot commented Dec 13, 2021 •

edited

Loading

breezewish commented Dec 14, 2021

breezewish left a comment

breezewish commented Dec 16, 2021

CLAassistant commented Dec 19, 2021 •

edited

Loading

shhdgit left a comment

baurine left a comment

breezewish left a comment

baurine left a comment

breezewish commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

chore: support multiple profiling types #1095

chore: support multiple profiling types #1095

Conversation

YiniXu9506 commented Dec 13, 2021

What did

ti-chi-bot commented Dec 13, 2021 • edited Loading

breezewish commented Dec 14, 2021

breezewish left a comment

Choose a reason for hiding this comment

breezewish commented Dec 16, 2021

CLAassistant commented Dec 19, 2021 • edited Loading

shhdgit left a comment

Choose a reason for hiding this comment

baurine left a comment

Choose a reason for hiding this comment

breezewish left a comment

Choose a reason for hiding this comment

baurine left a comment

Choose a reason for hiding this comment

breezewish commented Dec 22, 2021

ti-chi-bot commented Dec 22, 2021

ti-chi-bot commented Dec 13, 2021 •

edited

Loading

CLAassistant commented Dec 19, 2021 •

edited

Loading