Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster_info): fix error for hosts/disks/statistics page #1664

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Mar 26, 2024

This PR fixes the following error pages:

image
image
image

@ti-chi-bot ti-chi-bot bot requested a review from Renkai March 26, 2024 11:07
@ti-chi-bot ti-chi-bot bot added the size/M label Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 3b9def8
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/6602ac774b31c50008c5cc69
😎 Deploy Preview https://deploy-preview-1664--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 23.68%. Comparing base (c32ca0c) to head (3b9def8).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1664       +/-   ##
===========================================
+ Coverage    8.99%   23.68%   +14.68%     
===========================================
  Files         131      177       +46     
  Lines       13704    16055     +2351     
===========================================
+ Hits         1233     3802     +2569     
+ Misses      12338    11968      -370     
- Partials      133      285      +152     
Flag Coverage Δ
backend_integration 8.98% <0.00%> (-0.01%) ⬇️
backend_ut 26.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32ca0c...3b9def8. Read the comment docs.

Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants